Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330658

Summary:	ECoreEditor cannot be used in RCP apps due to dependencies on org.eclipse.ui.ide
Product:	[Modeling] EMF	Reporter:	Michael Spertus <mike>
Component:	Tools	Assignee:	Dave Steinberg <davidms>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Michael Spertus

2010-11-19 08:08:53 EST

Build Identifier: 20100917-0705

I am generating an RCP project. Since my model references ecore.ecore, the generated ModelEditorAdvisor references org.eclipse.emf.ecore.presentation.EcoreEditor, which references org.eclipse.ui.ide.IGotoMarker, which certainly seems like it shouldn't be imported into an RCP application. When I posted on the EMF newsgroup, Ed Merks asked me to create a bugzilla


Reproducible: Always

Steps to Reproduce:
1. Create a model that reference ecore.ecore
2. Set the genmodel to create a RCP app
You should get an error that org.eclipse.ui.ide.IGotoMarker is indirectly referenced from required class files.

Comment 1 Ed Merks

2010-11-19 08:54:20 EST

The advisor should only referenced editors that are generated as part of the same plugin, not editors generated from used GenPackages from other GenModels.

Comment 2 Ed Merks

2010-11-19 13:07:44 EST

In particular, it looks like GenModel.getAllGenPackagesWithConcreteClasses shouldn't be returning any usedGenPackages.  I've committed the change for that for EMF 2.7.

Comment 3 Ed Merks

2010-12-13 16:42:46 EST

The fixes are available in a published build.

Comment 4 Ed Merks

2010-12-14 23:28:08 EST

Try again to resolve as fixed (and available in a build).

Comment 5 Ed Merks

2010-12-14 23:29:45 EST

Oh, I guess I have to close them!