Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330606

Summary: [Theme] ToolItem:selected background color broken
Product: [RT] RAP Reporter: Austin Riddle <austin.riddle>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tbuschto
Version: 1.4   
Target Milestone: 1.4 M4   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Austin Riddle CLA 2010-11-18 14:52:51 EST 
Version: CVS HEAD

While Re-syncing from 2 weeks ago to now, our toolitem theme is broken.
The background-image settings for the selected state for toolitems seems to be ignored.

The culprit seems to be the change from version 1.14 to 1.15 in GraphicsMixin.js

If we use version 1.14, the theme works great.  Using 1.15 it is broken.

Here are the applicable entries from our theme.css:

* {
  color: black;
  font: normal 11px Arial, Helvetica, sans-serif;
}

Composite {
  padding: 0px;
  opacity: 1;
  background-color: rgb( 248, 248, 255 );
  background-image: none;
  /*border: none;*/
}

ToolItem {
    background-color: transparent;
    padding: 2px 3px;
    animation: hoverOut 500ms ease-out;
}

ToolItem:hover {
  background-image: gradient(
    linear, left top, left bottom,
    from( #eee9e9 ),
    to( #c0c0c0 )
  );
  border-radius: 4px 4px 4px 4px;
}

ToolItem:pressed, ToolItem:pressed:selected {
	border: 1px solid #5b5b5b;
	border-radius: 4px 4px 4px 4px;
	background-image: gradient(
    linear, left top, left bottom,
    from( #c0c0c0 ),
    to( #828282 )
  );
}

ToolItem:selected {
	border: 1px solid #5b5b5b;
	border-radius: 4px 4px 4px 4px;
	background-color: inherit;
	background-image: gradient(
    linear, left top, left bottom,
    from( #b0b0b0 ),
    color-stop( 20%, #eee9e9 )
    to( #eee9e9 )
  );
}

ToolBar {
	background-color: inherit;
}
Comment 1 Tim Buschtoens CLA 2010-11-19 06:54:45 EST 
Fixed in CVS HEAD.

This was the result of a hardcoded image in AppearanceBase.js, a pre-existing bug in GraphicsMixin.js and the fix of Bug 329832 making these issues visible.

I fixed GraphicsMixin and made the hardcoded image themable. I adjusted the default and classic theme (and their tests) accordingly.

Austin, please confirm that it works as you expect now.
Comment 2 Austin Riddle CLA 2010-11-19 13:17:52 EST 
(In reply to comment #1)
> Fixed in CVS HEAD.
> 
> This was the result of a hardcoded image in AppearanceBase.js, a pre-existing
> bug in GraphicsMixin.js and the fix of Bug 329832 making these issues visible.
> 
> I fixed GraphicsMixin and made the hardcoded image themable. I adjusted the
> default and classic theme (and their tests) accordingly.
> 
> Austin, please confirm that it works as you expect now.

Works great!  Thanks Tim.