Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330574

Summary: [Filters] org.eclipse.core.resources.filterMatchers extension point lists AbstractFileInfoMatcher in wrong package
Product: [Eclipse Project] Platform Reporter: Christian Walther <walther>
Component: ResourcesAssignee: Szymon Brandys <Szymon.Brandys>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3    
Version: 3.6   
Target Milestone: 3.7 M4   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
proposed patch Szymon.Brandys: iplog+

Description Christian Walther CLA 2010-11-18 10:11:04 EST
Build Identifier: 20100917-0705

The schema for extension point org.eclipse.core.resources.filterMatchers (http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.core.resources/schema/filterMatchers.exsd?revision=1.1&view=markup) specifies that the class to implement the matcher should be based on "org.eclipse.core.resources.AbstractFileInfoMatcher". Such a class doesn't exist, the AbstractFileInfoMatcher class actually resides in package org.eclipse.core.resources.filtermatchers (http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.core.resources/src/org/eclipse/core/resources/filtermatchers/AbstractFileInfoMatcher.java?revision=1.6&view=markup).

I propose the attached patch to the schema (untested since I'm not currently set up to build Eclipse from CVS, but should be straightforward enough).

Reproducible: Always

Steps to Reproduce:
1. In an Eclipse plugin project, make a new extension to point org.eclipse.core.resources.filterMatchers.
2. Click on the "class" hyperlink under Extension Element Details to bring up the "New Java Class" dialog.
3. Click Finish, accepting the default values in the dialog.
4. Note the error "org.eclipse.core.resources.AbstractFileInfoMatcher cannot be resolved to a type" in the generated class.
5. Change the superclass to "org.eclipse.core.resources.filtermatchers.AbstractFileInfoMatcher" and note that the error goes away.
Comment 1 Christian Walther CLA 2010-11-18 10:11:45 EST
Created attachment 183383 [details]
proposed patch
Comment 2 Szymon Brandys CLA 2010-11-26 10:52:46 EST
Fixed in HEAD. Thanks Christian.