Bug 330566

Description Albert 2010-11-18 08:49:03 EST

Build Identifier: 3.5.2

I have encountered a strange behavior when setting minimum composite width when moving sash. I have two composites inside a SWT.HORIZONTAL style SashForm. When I want to set a limit how far to the right Sash can be moved, I'm using a code, which works on Windows and GTK, but when running this code on Mac OS X (10.6), once the sash is moved to this limit, "West-East" cursor won't appear anymore when hovering with a mouse over it, and Sash cannot be no longer moved. If I resize the shell, cursor reappears and Sash can be moved again.

I opened a topic on Eclipse newsgroups (http://www.eclipse.org/forums/index.php?t=msg&th=198780&start=0&S=dc4988e7f16e0cde24de91b976be6e48) and moving the sashForm.layout(); to asyncExec() somehow bypasses this behavior.

This code works fine on Linux and Windows.


Best regards,

Albert


Reproducible: Always

Steps to Reproduce:
Please run the following snippet:

import org.eclipse.swt.SWT;
import org.eclipse.swt.custom.SashForm;
import org.eclipse.swt.events.SelectionAdapter;
import org.eclipse.swt.events.SelectionEvent;
import org.eclipse.swt.graphics.Color;
import org.eclipse.swt.layout.FormAttachment;
import org.eclipse.swt.layout.FormData;
import org.eclipse.swt.layout.FormLayout;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Sash;
import org.eclipse.swt.widgets.Shell;

public class SashFormTest
{
    // Mimumum width of right composite
    final static int MIN_WIDTH = 200;
    
    public static void main (String [] args)
    {
        Display display = new Display ();
        
        final Shell shell = new Shell(display);        
        shell.setLayout(new FormLayout());        
        shell.setText("SashFormTest");
        
        final SashForm sashForm = new SashForm(shell, SWT.HORIZONTAL);
        
        sashForm.setLayout(new FormLayout());
        {
            FormData formData = new FormData();
            formData.top = new FormAttachment(0, 0);            
            formData.bottom = new FormAttachment(100, 0);
            formData.left = new FormAttachment(0, 0);            
            formData.right = new FormAttachment(100, 0);
            sashForm.setLayoutData(formData);
        }
        
        Composite leftComposite = new Composite(sashForm, SWT.NONE);
        leftComposite.setLayout(new FormLayout());
        {
            FormData formData = new FormData();
            formData.top = new FormAttachment(0, 0);            
            formData.bottom = new FormAttachment(100, 0);
            formData.left = new FormAttachment(0, 0);            
            formData.right = new FormAttachment(100, 0);
            leftComposite.setLayoutData(formData);
        }
        leftComposite.setBackground(new Color(shell.getDisplay(), 255, 0, 0));
                
        Composite rightComposite = new Composite(sashForm, SWT.NONE);        
        rightComposite.setLayout(new FormLayout());
        {
            FormData formData = new FormData();
            formData.top = new FormAttachment(0, 0);            
            formData.bottom = new FormAttachment(100, 0);
            formData.left = new FormAttachment(0, 0);            
            formData.right = new FormAttachment(100, 0);
            rightComposite.setLayoutData(formData);
        }
        rightComposite.setBackground(new Color(shell.getDisplay(), 0, 255, 0));
        
        sashForm.setWeights(new int[] {30, 70});
        
        shell.setSize(500, 200);
        
        // Get Sash
        Sash sash = getSashes(sashForm);
        
        // Composite on the right side of the sash
        // is always at least 200 px wide, when sash is moved
        sash.addSelectionListener(new SelectionAdapter ()
        {                     
            public void widgetSelected(SelectionEvent event)
            {   
                if (event.x >= shell.getBounds().width - MIN_WIDTH)
                {   
                    int shellWidth = shell.getBounds().width;
                    
                    // Calculate new ratio for sashes weights                    
                    double ratio = (double)shellWidth / Math.abs(shell.getBounds().width - MIN_WIDTH);                                            
                    double percent = 100 / ratio;                  
                    
                    int percentRounded = (int) Math.floor(percent);
                    
                    sashForm.setWeights(new int[]{percentRounded, 100 - percentRounded});                                      
                    sashForm.layout();                      
                }
            }
        });
        
        shell.open ();
        
        while (!shell.isDisposed ())
        {
            if (!display.readAndDispatch())
            {
                display.sleep ();
            }   
        }
        display.dispose ();
    }
    
    private static Sash getSashes(SashForm sf)
    {
        Control control[] = sf.getChildren();
        for (int i = 0; i < control.length; ++i)
        {            
            if (control[i] instanceof Sash)
            {   
                return (Sash)control[i];
            }
        }
        return null;
    }
}