Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330540

Summary: Shell with SWT.TOOL style doesn't take focus any more
Product: [Eclipse Project] Platform Reporter: Markus Keller <markus.kell.r>
Component: SWTAssignee: Scott Kovatch <skovatch>
Status: RESOLVED FIXED QA Contact: Silenio Quarti <Silenio_Quarti>
Severity: normal    
Priority: P3 CC: skovatch
Version: 3.7   
Target Milestone: 3.7 M4   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Markus Keller CLA 2010-11-18 03:44:27 EST
I20101116-0800 Cocoa

A Shell with SWT.TOOL style doesn't take focus any more. This can be seen in the ControlExample and in the Key Assist dialog (Command+Shift+L).
Comment 1 Scott Kovatch CLA 2010-12-06 14:53:23 EST
This was subtly introduced when I added NSNonactivatingPanelMask to support the minimize button on TOOL windows. A borderless TOOL window keeps the NSNonactivatingPanelMask but clears the NSUtilityWindowMask bit. This caused canBecomeKeyWindow to return false since we weren't checking for that possibility.
Comment 2 Scott Kovatch CLA 2010-12-06 14:54:42 EST
Fixed > 20101206.