Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330485

Summary: Cannot revert empty line addition to Arguments field
Product: [Eclipse Project] Platform Reporter: Michael Rennie <Michael_Rennie>
Component: AntAssignee: Pradeep Balachandran <pradeepb>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: 3.7   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard: stalebug

Description Michael Rennie CLA 2010-11-17 12:11:20 EST
I20101116-0800

while verifying bug 330440, I found that if you hit enter in the arguments field you cannot revert it.

Steps

1. create new external tools launch configuration
2. navigate to the Arguments field and hit the Enter key
3. A new line is created and the revert button is enabled [OK]
4. press the revert button

Expected

Pressing the revert button would revert the new line addition and put the configuration back to a clean state

Happens

The new line is reverted, but the revert button remains enabled.

Without debugging the code I would guess that entering the newline adds in a new attribute to the config that is not there by default, so when you revert it the value of the new attribute is removed, but the new attribute is still in the configuration, so the dialog still thinks it is dirty.

The common fix to this kind of problem (if that is the cause) is to make sure the attribute is included during the call to setDefaults(...) when the new configuration is created.
Comment 1 Eclipse Genie CLA 2020-04-17 13:26:16 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.