Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330468

Summary:

Memory Browser View: Incorrect replacement of address field expression

Product:

[Tools] CDT

Reporter:

Andre St. Laurent <st.laurent>

Component:

cdt-debug

Assignee:

Randy Rohrbach <Randy.Rohrbach>

Status:

RESOLVED FIXED

QA Contact:

Ken Ryall <ken.ryall>

Severity:

normal

Priority:

CC:

cdtdoug, pawel.1.piech, Randy.Rohrbach, st.laurent

Version:

8.0

Flags:

Randy.Rohrbach: review? (pawel.1.piech)

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Changes the scrolling logic	none
Corrects "x" error handling and improper replacement of old bad expression.	cdtdoug: iplog-
Fixes the 'x' decoration issue	cdtdoug: iplog+

Description Andre St. Laurent

2010-11-17 11:05:56 EST

Memory Browser View:  If a valid expression is entered into the address field and evaluated then an invalid expression is entered and evaluated, on the next run control event the previously-evaluated valid expression replaces the current expression in the address field.

Steps to reproduce:

1) Debug something (I used a C program) and stop at a breakpoint.

2) Enter a valid expression in the Memory Browser View and evaluate it by clicking the GO button, or entering RETURN after entry; note valid address and memory contents in address and memory contents panes.

3) Enter an invalid expression.

4) Step one statement.  Note that the address field now displays the previous/valid expression.

Note: The code that causes this behavior seems to appear and disappear from the MemoryBrowser class in alternating versions, thus, your mileage may vary.

I'll have a fix for this in an upcoming patch that will be submitted by Randy R.

Comment 1 Samantha Chan

2010-11-17 11:21:56 EST

Not a platform defect, CDT defect.

Comment 2 Randy Rohrbach

2011-01-18 23:37:18 EST

Created attachment 187073 [details]
Changes the scrolling logic

Comment 3 Randy Rohrbach

2011-01-18 23:38:17 EST

Ignore the attachment "Changes the scrolling logic". I added the wrong patch.

Randy

Comment 4 Randy Rohrbach

2011-01-22 20:37:51 EST

Created attachment 187371 [details]
Corrects "x" error handling and improper replacement of old bad expression.

Andre St. Laurent created this patch. I am just posting it for him.

Randy

Comment 5 Randy Rohrbach

2011-01-22 20:38:53 EST

I am taking this one to apply the patch created by Andre St. Laurent of Wind River.

Randy

Comment 6 Pawel Piech

2011-01-24 11:57:06 EST

(In reply to comment #5)
> I am taking this one to apply the patch created by Andre St. Laurent of Wind
> River.
> 
> Randy

Hi Andre and Randy.  For purposes of the automated IP log, it would be better if Andre himself posted the patch before you marked it with iplog+

Comment 7 Andre St. Laurent

2011-01-24 15:13:46 EST

Created attachment 187466 [details]
Fixes the 'x' decoration issue

This patch obsoletes the prior patch.  However, Bugzilla will not allow me to mark it obsolete.

Comment 8 Randy Rohrbach

2011-02-07 14:01:29 EST

I applied Andre's patch minus the messages.properties file. Which was
mistakenly edited but does not apply.

Randy
781-364-2226

Pawel please review