Bugzilla – Full Text Bug Listing
| Summary: | Warning for missing localization or manifest includes in build.properties have unclear messages | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Michael Rennie <Michael_Rennie> |
| Component: | UI | Assignee: | PDE-UI-Inbox <pde-ui-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | aniefer, curtis.windatt.public |
| Version: | 3.6 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | stalebug | ||
Andrew, to include a file in build.properties do you need to include it's parent directories? The quick fix has been around for at least a little while, but to me it seems like a bad assumption. If the user only wants to include a specific file, adding the parent directories would include more than intended. (In reply to comment #1) > Andrew, to include a file in build.properties do you need to include it's > parent directories? > > The quick fix has been around for at least a little while, but to me it seems > like a bad assumption. If the user only wants to include a specific file, > adding the parent directories would include more than intended. You are right, You don't need the parent directories since as you say, you may only want one file from that directory. This bug is a feature. We explicitly check that the manifest folder, osgi folder, fragment/plugin.xml and localization files are included in the build.properties. We could try and do some better processing here, provide specific messages about why we are suggesting that the folder should be included. We could also remove the redundant file includes if the quick fix to add the parent directory is used. It would be appropriate to have more granular control over these warnings as including the folders is a recommended practice, not required. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
I20101116-0800 After a full build of my workspace today I noticed two warnings on the build.properties for one of my bundles (they could have been there before and I might have not noticed): An entry for OSGI-INF/ is required in bin.includes An entry for OSGI-INF/l10n/ is required in bin.includes This is what the build.properties currently looks like: source.. = src/ output.. = bin/ bin.includes = META-INF/,\ .,\ about.html,\ OSGI-INF/l10n/bundle.properties src.includes = about.html This is what the manifest.mf looks like (in case it helps): Manifest-Version: 1.0 Bundle-ManifestVersion: 2 Bundle-Name: %Bundle-Name Bundle-Vendor: %providerName Bundle-SymbolicName: org.eclipse.wst.jsdt.debug.rhino.debugger Bundle-Version: 1.0.100.qualifier Bundle-RequiredExecutionEnvironment: J2SE-1.4 Export-Package: org.eclipse.wst.jsdt.debug.internal.rhino.debugger;x-internal:=true, org.eclipse.wst.jsdt.debug.internal.rhino.transport;x-friends:="org.eclipse.wst.jsdt.debug.rhino", org.eclipse.wst.jsdt.debug.rhino.debugger, org.eclipse.wst.jsdt.debug.rhino.debugger.shell Import-Package: org.mozilla.javascript;resolution:=optional, org.mozilla.javascript.debug;resolution:=optional, org.mozilla.javascript.tools;resolution:=optional, org.mozilla.javascript.tools.shell;resolution:=optional Require-Bundle: org.eclipse.wst.jsdt.debug.transport;bundle-version="1.0.0" I would assume there should be no warnings reported as the build.properties currently includes the OSGI-INF/l10n/bundle.properties entry.