Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330461

Summary: [JFace] Improve support for ContentProposal
Product: [RT] RAP Reporter: Tim Buschtoens <tbuschto>
Component: JFaceAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: hihn, tbuschto
Version: 1.4   
Target Milestone: 1.5 M5   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 329639, 337313, 337316, 349523, 350053, 365588, 365723, 366150, 367923    
Bug Blocks:    

Description Tim Buschtoens CLA 2010-11-17 10:20:42 EST 

    


    


      



        
          Comment 1
        

        
          Tim Buschtoens CLA

        

        
        

        
          2010-11-17 10:22:26 EST
        

      






I pressed Enter and submitted by mistake. Description follows soon.

    


    


      



        
          Comment 2
        

        
          Tim Buschtoens CLA

        

        
        

        
          2010-11-17 11:09:59 EST
        

      






JFace FieldAssist currently has the following issues in RAP:

- Can not focus the list using the arrow-keys. (See Bug 329639)
- Popup does not close when clicking on the document-background. 
- The description-popup should be opend with some delay after the assistant is opend (without any actions), but its not.
- The content of the description popup is not updated correctly.

While the position of the popup might initially seem strange compared to similar widgets, in browser URL-bars for example, its actually correct. Its supposed to be adjusted to the position of the caret.

    


    


      



        
          Comment 3
        

        
          Tim Buschtoens CLA

        

        
        

        
          2012-01-12 05:54:20 EST
        

      






Bug 329639 has been fixed. I quickly re-enabled some code in ContentProposalAdapter, and the issue with the arrow-keys seems to be fixed now. Perhaps someone a bit more more familiar with JFace (i.e. Ivan) could enable, test and commit this code. The bug should stay open for now as the other issues may still persist.

Note that there was a strange line where a "&&" seemd to be missing:

if (e.keyCode != SWT.CAPS_LOCK e.keyCode != SWT.NUM_LOCK 

should probably be 

if (e.keyCode != SWT.CAPS_LOCK && e.keyCode != SWT.NUM_LOCK

    


    


      



        
          Comment 4
        

        
          Ivan Furnadjiev CLA

        

        
        

        
          2012-01-25 08:23:50 EST
        

      






Enabled ARROW_UP, ARROW_DOWN, PAGE_UP, PAGE_DOWN, HOME and END keys. Scrollbar listener on proposal table has been enabled too.

    


    


      



        
          Comment 5
        

        
          Ivan Furnadjiev CLA

        

        
        

        
          2012-01-31 17:01:19 EST
        

      






The only issue from the comment#2 which is not yet fixed is: "Popup does not close when clicking on the document-background". This problem doesn't exist in RCP as it is not possible to click outside the application shell. Similar problem has been discussed in bug 368940. Read bug 368940 comment#1 for a potential fix - clicking on the document background should not remove the focus from the last focused shell/control. That's why I will close this bug as fixed.