Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330365

Summary:	GEF and Draw2D should specify project specific settings for code formatting
Product:	[Tools] GEF	Reporter:	Austin Riddle <austin.riddle>
Component:	GEF-Legacy GEF (MVC)	Assignee:	Ian Bull <irbull>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ahunter.eclipse, nyssen
Version:	3.7
Target Milestone:	3.6.2 (Helios SR2)
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Austin Riddle

2010-11-16 10:13:18 EST

Version: CVS HEAD

Steps to reproduce:

1. Check out Draw2D and GEF into a workspace that has custom code formatting settings (non-default, perhaps specific for your organization).

2. Open a file in the GEF or Draw2D project and make a small change.

3. Notice that the code is changed to match the workspace settings, not the convention (Eclipse [built-in]) that the code has been checked in with.


The specific problem is easy to fix locally, by changing the project specific formatting settings, but it seems like the project should specify this and it should be checked in with the project.

Comment 1 Anthony Hunter

2010-11-16 11:14:04 EST

This should have been completed by Bug 308372 in 3.6. The settings are in CVS. No?

Comment 2 Austin Riddle

2010-11-16 11:56:14 EST

Thanks for directing me to that past bug. When I check out Draw2D and GEF from HEAD the settings that accompany the projects do not specify project specific formatting.  I just tried to revert my .settings dir and update from HEAD again and the problem remains.

(In reply to comment #1)
> This should have been completed by Bug 308372 in 3.6. The settings are in CVS.
> No?

Comment 3 Alexander Nyßen

2010-11-16 13:16:53 EST

(In reply to comment #2)
> Thanks for directing me to that past bug. When I check out Draw2D and GEF from
> HEAD the settings that accompany the projects do not specify project specific
> formatting.  I just tried to revert my .settings dir and update from HEAD again
> and the problem remains.
> 
> (In reply to comment #1)
> > This should have been completed by Bug 308372 in 3.6. The settings are in CVS.
> > No?

Well, actually we have only specified a save action as part of bug #308372 in each of our plug-ins to automatically force a formatting of the code upon saving. I thought a plug-in specific formatter setting was not needed, and the Eclipse built-in rules would be taken as default. Obviously this does not seem to be the case (while we are obviously all working with the default settings in our workspace). 

I will take care of setting project specific formatters to Eclipse built-in for all Draw2d/GEF plug-ins.

Comment 4 Alexander Nyßen

2010-11-16 13:59:52 EST

Added project-specific formatter settings (using the Eclipse built-in formatter profile) for the following plug-ins:

org.eclipse.draw2d
org.eclipse.draw2d.examples
org.eclipse.draw2d.test
org.eclipse.gef
org.eclipse.gef.examples.flow
org.eclipse.gef.examples.logic
org.eclipse.gef.examples.shapes
org.eclipse.gef.examples.text
org.eclipse.gef.examples.ui.pde
org.eclipse.gef.test

in the R3_6_maintenance branch as well as in cvs HEAD (3.7), where I additionally also applied respective settings to the following (non-branched) plug-ins:

org.eclipse.gef.examples.digraph1
org.eclipse.gef.examples.digraph2
org.eclipse.gef.examples.ediagram

I further verified that the following zest plug-ins already specified the Eclipse built-in formatter as a project-specific setting, namely:

org.eclipse.zest.dot.export
org.eclipse.zest.dot.import
org.eclipse.zest.dot.ui

What remains is to provide respective optiosns for the remaining zest plugins:

org.eclipse.zest does not specify project specific setting yet
org.eclipse.zest.tests uses 'Mylar based on Eclipse [built-in]'
org.eclipse.zest.core and org.eclipse.zest.layouts use unmanaged 'Ian's Style' profile

Comment 5 Alexander Nyßen

2010-11-16 14:04:28 EST

Ian, reassigning this to you because the Zest plug-ins mentioned below will probably have to be taken care of.

Comment 6 Anthony Hunter

2010-12-09 10:59:29 EST

Ping, this needs to be done by the Zest team.

Comment 7 Ian Bull

2010-12-09 18:50:16 EST

I've fixed this in head and the 3.6 maintenance branch.