Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330342

Summary:

Memory Browser does not work when memory block retrieval does not implement IAdaptable

Product:

[Tools] CDT

Reporter:

Anton Leherbauer <aleherb+eclipse>

Component:

cdt-memory

Assignee:

Anton Leherbauer <aleherb+eclipse>

Status:

RESOLVED FIXED

QA Contact:

Ted Williams <ted>

Severity:

minor

Priority:

CC:

cdtdoug

Version:

7.0

Target Milestone:

7.0.2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Fix	aleherb+eclipse: iplog-

Description Anton Leherbauer

2010-11-16 07:38:38 EST

In MemoryBrowser.createMemoryBlock() the retrieval object needs to be IAdaptable to IMemoryBlockRetrievalExtension which is inconsistent with the Memory view.
It should test for instanceof first.

Comment 1 Anton Leherbauer

2010-11-16 07:56:24 EST

Created attachment 183216 [details]
Fix

Comment 2 Anton Leherbauer

2010-11-16 08:01:04 EST

Committed to HEAD and cdt_7_0.

Comment 3 CDT Genie

2010-11-16 08:23:04 EST

*** cdt cvs genie on behalf of aleherbau ***
Bug 330342 - Memory Browser does not work when memory block retrieval does not implement IAdaptable

[*] MemoryBrowser.java 1.29.2.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.memorybrowser/src/org/eclipse/cdt/debug/ui/memory/memorybrowser/MemoryBrowser.java?root=Tools_Project&r1=1.29.2.3&r2=1.29.2.4

[*] MemoryBrowser.java 1.35 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.memorybrowser/src/org/eclipse/cdt/debug/ui/memory/memorybrowser/MemoryBrowser.java?root=Tools_Project&r1=1.34&r2=1.35