Bugzilla – Full Text Bug Listing
| Summary: | Virgo Snaps example with Spring MVC | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [RT] Virgo | Reporter: | Patsy Phelan <pphelan> | ||||||
| Component: | samples | Assignee: | Chris Frost <eclipse> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | eclipse | ||||||
| Version: | unspecified | Flags: | eclipse:
iplog+
|
||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Patsy Phelan
Created attachment 183179 [details]
Sample Code Bundles.
I have developed the sample code and can contribute this to eclipse on behalf of myself and my employer if need be.
I have been setting up a example of SNAPS / Spring MVC using OSGI services. So I
currently have a small example with the following bundles:
menu-sample-deployment.plan
- deployment plan - will deploy to http://localhost:8080/menu
sample.api
- Interface & SimpleDao
sample.imp
- Interface Implementation exporting OSGi Service
sample.snap
- Simple SNAP, imports my OSGi Service
- Spring MVC - Index (listing of Daos via Service)
- Add Dao form
- Delete Dao handler
animal.menu.bar - (the dynamic tabs example - as the snap.host).
- minor tweak in the web.xml.
This is pretty generic and very much along the lines of the samples under the
snaps code base. I can contribute this example to the codebase and to eclipse if it
is useful for the project. I have no problem with you guys reviewing it and making
any changes you want to it. I have moved the code into my local git repo for snaps and
integrated it in with the menu-bar sample.
I am not a web (mvc) expert but it works OK at the moment for our internal demo of snaps - so you may have suggestions to make it better on the web front :)
HI, This is excellent. Thank you. As it is over 250 lines I have to run it through the legal process, please could you make sure all the code files have the right license header (EPL). Also, please state that 100% of the code is your own work, we need that wording to make sure it goes through. Once that is done I'll add it to the snaps repo as a demo application. Will do, I will add the headers tonight and upload a new patch. The only one that is not mine as such are the modifications within the build.versions, animal.menu.bar (existing code within the Springsource examples). That's fine, it's already code from Eclipse so it won't matter. Thanks for the effort. Created attachment 183532 [details]
Apply to previous patch to add copyright headers (EPL)
Additional patch which applies the EPL license/copyright to the previous patch. There are only 5 java files which need this.
Hi Chris, All the code and files under the sample.api / sample.impl / sample.snap are 100% my own work and as such is being contributed to virgo.snaps if it is wanted under the terms of EPL. I have listed my organisation as Pouzin Society as I initiated and completed these examples for the members of this research group. I hope this is all you need - if there is anything else - let me know. ~Patsy Hi, Just to let everyone know, I have started the legal checking process. Will hopefully be straight forward and I'll be able to get the code in soon. Thanks again. The legal process is complete and I will commit the code soon, once done I will close this issue. I have applied the patch and given you credit. Thanks again. For reference the CQ is here https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4691 Sorry, I lie. It's here. http://dev.eclipse.org/ipzilla/show_bug.cgi?id=4663 |