Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330266

Summary:

[ui] XML reload grammar / dependencies actions always visible

Product:

[WebTools] WTP Source Editing

Reporter:

Nick Sandonato <nsand.dev>

Component:

wst.xml

Assignee:

Nick Sandonato <nsand.dev>

Status:

RESOLVED FIXED

QA Contact:

Nitin Dahyabhai <thatnitind>

Severity:

normal

Priority:

Version:

3.3

Target Milestone:

3.3 M4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	none

Description Nick Sandonato

2010-11-15 11:56:10 EST

Bug 303379 introduced a new property tester that is used to identify when XML editors are active in order to always display these two actions. But, the property tester isn't being forced to activate the plug-in. This causes the icons to always be visible until the XML UI plug-in is loaded.

Comment 1 Nick Sandonato

2010-11-15 11:57:53 EST

Created attachment 183140 [details]
patch

Comment 2 Nitin Dahyabhai

2010-11-15 12:25:56 EST

Since the two commands don't actually reference the XMLMultiPageEditorPart class, is there any reason not to just test for the input's content type instead of a specific editor?

Comment 3 Nick Sandonato

2010-11-15 14:09:12 EST

We want to make sure that only editors that utilize are editor are endowed with this functionality.