Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330259

Summary:

[disassembly] debug context is not per workbench window

Product:

[Tools] CDT

Reporter:

Patrick Chuong <pchuong>

Component:

cdt-debug-dsf

Assignee:

Patrick Chuong <pchuong>

Status:

RESOLVED FIXED

QA Contact:

Pawel Piech <pawel.1.piech>

Severity:

normal

Priority:

CC:

aleherb+eclipse, cdtdoug

Version:

7.0

Flags:

pchuong: iplog-

Target Milestone:

8.0

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch - retrieves debug context per workbench window	none
new patch - retrives debug context and register listener per window service	pchuong: iplog-

Description Patrick Chuong

2010-11-15 10:46:22 EST

When you open multiple workbench windows with multiple disassembly views open, than selecting the stackframe in one workbench windows causes the other workbench window's disassembly view to update as well.

Comment 1 Patrick Chuong

2010-11-15 10:48:54 EST

Created attachment 183126 [details]
patch - retrieves debug context per workbench window

Comment 2 Anton Leherbauer

2010-11-16 03:14:50 EST

Right, I tend to forget that there can be multiple windows.  I think we should also register the IDebugContextListener with the window-specific context service.

Comment 3 Patrick Chuong

2010-11-16 10:05:48 EST

Created attachment 183228 [details]
new patch - retrives debug context and register listener per window service

I intended to change the listener when I submit a view pin&clone patch to CDT, I guess this is a good fix for now. I'll have to change the addDebugListener to provide the view IDs later.

I also made an addition nullpointer fix in this patch, getTopAddress() causes a nullpointer when the view is close.

Comment 4 Patrick Chuong

2010-11-24 09:42:09 EST

I have commit the patch to head.

Comment 5 CDT Genie

2010-11-24 10:23:05 EST

*** cdt cvs genie on behalf of pchuong ***
Bug 330259 - [disassembly] debug context is not per workbench window

[*] DisassemblyPart.java 1.40 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyPart.java?root=Tools_Project&r1=1.39&r2=1.40