Bugzilla – Full Text Bug Listing
| Summary: | [Compatibility] Part getting closed by workbench window shutdown causes part activation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Thomas Kratz <eiswind> | ||||
| Component: | UI | Assignee: | Remy Suen <remy.suen> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Remy Suen <remy.suen> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | remy.suen | ||||
| Version: | 1.0 | ||||||
| Target Milestone: | 4.1 M4 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Thomas Kratz
Second part of the exception:
Caused by: org.eclipse.swt.SWTException: Widget is disposed
at org.eclipse.swt.SWT.error(SWT.java:4091)
at org.eclipse.swt.SWT.error(SWT.java:4006)
at org.eclipse.swt.SWT.error(SWT.java:3977)
at org.eclipse.swt.widgets.Widget.error(Widget.java:468)
at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:340)
at org.eclipse.swt.widgets.Widget.getData(Widget.java:525)
at org.eclipse.ui.part.MultiPageEditorPart.getEditor(MultiPageEditorPart.java:610)
at org.eclipse.ui.part.MultiPageEditorPart.getActiveEditor(MultiPageEditorPart.java:534)
at org.eclipse.ui.forms.editor.FormEditor.getActiveEditor(FormEditor.java:430)
at org.eclipse.ui.part.MultiPageEditorPart.getAdapter(MultiPageEditorPart.java:1173)
at org.eclipse.ui.internal.util.Util.getAdapter(Util.java:110)
at org.eclipse.ui.internal.WorkbenchPage.getShowInSource(WorkbenchPage.java:236)
at org.eclipse.ui.internal.WorkbenchPage.getContext(WorkbenchPage.java:240)
at org.eclipse.ui.internal.WorkbenchPage.updateShowInSources(WorkbenchPage.java:228)
at org.eclipse.ui.internal.WorkbenchPage.updateActivations(WorkbenchPage.java:171)
at org.eclipse.ui.internal.WorkbenchPage.access$7(WorkbenchPage.java:166)
at org.eclipse.ui.internal.WorkbenchPage$E4PartListener.partActivated(WorkbenchPage.java:134)
at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.firePartActivated(PartServiceImpl.java:170)
at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.setPart(PartServiceImpl.java:144)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:52)
Is this consistently reproducible? I can't seem to get it to happen with the PDE editors. Yes happens on every shutdown at my side. Don't know how to provide further help. Let me know (In reply to comment #3) > Yes happens on every shutdown at my side. Do you get the problem if you launch a second Eclipse instance and shutdown with PDE editors up? no it happens only with my own editors. maybe its in getAdapter where i should provide something from the superclasses ? (In reply to comment #5) > no it happens only with my own editors. If you make a very simple form editor (just make a few pages and put buttons in them or something), does the same problem occur? > maybe its in getAdapter where i should > provide something from the superclasses ? No, I don't think that's the problem. And if it is, why does your code work in 3.x? :) The editor is only some pages with textfields, labels and tables. But I have Actions in the Form Header Toolbar at org.eclipse.swt.widgets.Widget.dispose(Widget.java:446) at org.eclipse.jface.action.ToolBarManager.dispose(ToolBarManager.java:153) at org.eclipse.ui.internal.forms.widgets.FormHeading$6.widgetDisposed(FormHeading.java:772) is it there ? (In reply to comment #7) > The editor is only some pages with textfields, labels and tables. But I have > Actions in the Form Header Toolbar > at org.eclipse.swt.widgets.Widget.dispose(Widget.java:446) > at org.eclipse.jface.action.ToolBarManager.dispose(ToolBarManager.java:153) > at > org.eclipse.ui.internal.forms.widgets.FormHeading$6.widgetDisposed(FormHeading.java:772) > > is it there ? It's possible that's the cause although I think the PDE editors also have actions. If you comment out the action contribution code does the problem stop happening? Yes, if I completely remove the actions from the form toolbar, the exception does not occur anymore Created attachment 183311 [details]
WorkbenchWindow patch v1
Hi Thomas, could you give this patch a spin and see if it fixes your problem? Thanks.
Patch makes Exception go away. (In reply to comment #10) > Created an attachment (id=183311) [details] > WorkbenchWindow patch v1 Fix released to HEAD. Thanks for helping investigate the cause and testing the fix, Thomas! Please feel free to let us know if you see any other problems. |