Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330253

Summary:

[JEE Discoverer] JUnit test failure on Hudson

Product:

[Modeling] MoDisco

Reporter:

Nicolas Guyomar <nicolas.guyomar>

Component:

Technologies

Assignee:

Fabien Giquel <fabien.giquel>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

fabien.giquel, hugo.bruneliere, modisco.web-inbox

Version:

0.9.0

Flags:

fabien.giquel: indigo+

Target Milestone:

0.9.0 M4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch for JEE Deployment Descriptor xml version retrieving	fabien.giquel: iplog+

Description Nicolas Guyomar

2010-11-15 09:45:14 EST

Hi,

Tests for ejb-jar and webxml discoverers are failing on Hudson because some connection time out exceptions occurred while trying to get a DTD from sun server.

MoDisco Discoverer should not need an internet connection to work.

Here is a patch which determine the version of the discovered file without the need of a DTD

(a) I, Nicolas Guyomar, wrote 100% of the code of the contribution
(b) I have the right to contribute the code to Eclipse
(c) I want to contribute this code under EPL


Regards

Nicolas Guyomar

Comment 1 Nicolas Guyomar

2010-11-15 09:52:32 EST

Created attachment 183121 [details]
Patch for JEE Deployment Descriptor xml version retrieving

This patch uses a simple reader to determine the Doctype version of an xml file.

Comment 2 Fabien Giquel

2010-11-16 03:24:18 EST

Thks Nicolas,

Here is a contribution from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

The contribution has been commited into SVN (revision 3607)

Comment 3 Hugo Bruneliere

2011-01-11 05:19:27 EST

Bug fixed via a patch.