Bug 330205

Comment 1 Felipe Heidrich 2010-11-15 09:45:05 EST

The SWT Link control is different that GtkButtonLink.
GtkButtonLink can have only one link.
SWT Link, on the other hand, can have many links, in the format: text <link> text <link> ...

Isn't that right ?


Don't be sad about the colour being hard coded. 
1. the APIs to retrieve the value are not reliable (nobody sets it)
2. some platforms do not allow the colour to be changed (win32, etc), for that reason we forced the same behaviour on all the platforms

Comment 2 Pete Beardmore 2010-12-06 14:55:13 EST

Created attachment 184652 [details]
dark theme nightmare

Hi,

I'm the original IRC stakeholder.. ..apologies for missing this conclusion, but given the attached could i urge you to reconsider the 'WON'T FIX' status?

Many people struggle with the original winforms esq. theme being too bright / or simply out of place with the rest of their desktop theme. Changing the Eclipse theme in linux is already incredibly difficult as there seems to be an incredible amount of colours used beyond what is normally configured / required for a desktop, and many of these need to be changed in files, not just via the gui.

Not being able to configure 'some' colours essentially means a complete re-think on what colour configuring has been done already (and here i'm talking about the mass of work that must have gone into the pages at http://blog.edwards-research.com/2009/10/color-schemes-for-eclipse-cdt/ ..that i think most people requiring Eclipse theme tweaks eventually stumble upon). 
Also, the idea that 'because certain platforms aren't configurable then..' makes me sad too. Lack of configurability was a major factor in why i moved away from win32, and i imagine so for others too.

Thanks,
Pete.

Comment 3 Felipe Heidrich 2010-12-06 16:52:04 EST

(In reply to comment #2)
> Created an attachment (id=184652) [details]
> dark theme nightmare

What is the correct link color for this theme ?
Where can I download this theme ?

> Changing the
Eclipse theme in linux is already incredibly difficult as there seems to be an
> incredible amount of colours used beyond what is normally configured / required
> for a desktop, and many of these need to be changed in files, not just via the
> gui.

I'm afraid I can't help you with that.

> Not being able to configure 'some' colours essentially means a complete
> re-think on what colour configuring has been done already (and here i'm talking
> about the mass of work that must have gone into the pages at
> http://blog.edwards-research.com/2009/10/color-schemes-for-eclipse-cdt/

I've tried to use GtkWidget::"link-color" in the past, see:
http://library.gnome.org/devel/gtk/unstable/GtkWidget.html#GtkWidget--s-link-color
But that turned out to be a waste of time because no theme ever set this property. Maybe this has changed since the last time I tested.

SO, if the GTK theme does set "link-color" we can try to use that (instead of our default color). I think that is all I can do.

Will that help you ?

(Note that windows and mac will still have this limitation - and there it can not be changed.)

Comment 4 Pete Beardmore 2010-12-09 17:35:04 EST

Hi,

Many thanks for the reply. Implementing it as any of the various GTk link type widgets would be great, i'm pretty sure whichever is chosen, it's colour will be override-able in the gtkrc files.

The theme in question is actually an unofficial colour-scheme for KDE's qt based windows / widgets called 'elegant_new'. The setting 'Apply colors to non-KDE4 applications' in KDE's systemsettings does a great job of generating the GTKRC files needed to ensure GTk apps look consistent ..but it's not perfect ..hence one needs to fine tune on occasions when unusable colour mixes are found.

As for what is the correct colour for this theme, i imagine i'd tweak it be be some shade of grey or a more vibrant blue ..i won't know until i've experimented with the palette. Of course the default colour for the link should remain as it is now.

Thanks for your time
Pete.

Comment 5 Felipe Heidrich 2010-12-16 16:16:35 EST

I failed to find this theme for download.

Nevertheless, you have it right. Can you tell me if the GTK RC files generated for this theme have the GtkWidget::"link-color" set in them ? And if so, what is the value of it ?
Thank you, and sorry for the delayed reply (things got busy).

Comment 6 Pete Beardmore 2010-12-18 13:57:04 EST

(In reply to comment #5)
> I failed to find this theme for download.
 
I got it via systemsettings->application->appearance->colours->get new schemes ..and although it's called 'Elegant_New' when installed, the scheme is actually called 'Emotion', which is hosted at http://opendesktop.org/content/show.php?content=105913 ..apologies that i wasn't more thorough initially.

> Nevertheless, you have it right. Can you tell me if the GTK RC files generated
> for this theme have the GtkWidget::"link-color" set in them ? And if so, what
> is the value of it ?

It's not set by default no, it's something i'd want to set. If you require a default colour then should the 'all platform standard' original blue not be the choice?

> Thank you, and sorry for the delayed reply (things got busy).

Don't apologise, your time is appreciated. Thanks

Comment 7 Filip Wieladek 2012-05-04 04:17:40 EDT

I still do not understand why this issue cannot be fixed on the GTK platform. 

My theme of choice is a dark theme (as I sometimes program in the dark and do not like the monitor to blind me while doing so). It is also an issue for high contrast themes which is used by visually impaired people.

I do not really understand the argument "The value is not set by default...". If the setting is not set, why not simply fall back on the hardcoded value? In this case you provide a possibility to configure the value while still coping with unset values.

and FYI, the Human theme (an Ubuntu theme) does indeed set this value:

cat /usr/share/themes/Human/gtk-2.0/gtkrc | grep link
#GtkWidget      ::link-color           = @fg_color
#GtkWidget      ::visited-link-color   = shade (0.2, @fg_color)


I would really appreciate if you could do this simple fix. This is one of the issues which is holding me back to use my system theme on eclipse