Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330181

Summary:	[General] Papyrus shall use the GMF Command framework. (Rewrite GMF Actions with the Eclipse Framework)
Product:	[Modeling] Papyrus	Reporter:	Sébastien Gérard <sebastien.gerard>
Component:	Core	Assignee:	Vincent Lorenzo <vincent.lorenzo>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	Keywords:	plan
Version:	unspecified	Flags:	sebastien.gerard: indigo+ rschnekenburger: juno+
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:	Editors
Bug Depends on:	324274, 333569, 338648, 352872, 409933
Bug Blocks:

Description Sébastien Gérard

2010-11-13 17:08:45 EST

Papyrus shall the GMF Command framework.

Comment 1 Vincent Lorenzo

2010-11-16 02:39:39 EST

*** Bug 324274 has been marked as a duplicate of this bug. ***

Comment 2 Vincent Lorenzo

2010-11-25 07:24:17 EST

The GMF Framework doesn't allow 2 behaviors : 
- Add a keybinding for GMF Actions (with org.eclipseui.keybinding)
- Add a keybinding for GMF Actions in the Eclipse Preference
- Add an action in the GMF Menu, without using GMF API and ActionSet (deprecated)

That's why we should rewrite the GMF Action provided by the Menu Diagram, the GMF Toolbar and the popup Menu.

For more details, see the bug 324274

Comment 3 Vincent Lorenzo

2011-01-05 07:01:09 EST

In R3574 : CopyAppearancePropertiesAction is done.
In R3602 : The whole Menu View is copied: Grid, Rulers, Page Break, Recalculate Page Break and Snap To Grid
In R3603 : Adds a condition VisibleWhen for the Copy Appearance Properties Action

Comment 4 Vincent Lorenzo

2011-01-07 07:29:53 EST

In R3634 : done for Sort/Filter Contribution items
In R3636 : merge trunk with branch 0.7.2 for eop.diagram.common and oep.diagram.menu

Comment 5 Vincent Lorenzo

2011-01-18 12:02:06 EST

In R3757

Terminate the rewriting of the GMF Diagram Menu (except Line Style (forgotten in this commit)).
The Toolbar is not done yet entirely.

Comment 6 Vincent Lorenzo

2011-01-26 09:22:48 EST

In R3836 : Line Style menu is rewritten

Comment 7 Vincent Lorenzo

2011-02-02 08:19:05 EST

In R3871 : 
  the actions "All Connector Labels" and "No Connector Label" are rewritten and added to the filter menu.

Comment 8 Vincent Lorenzo

2011-02-03 09:30:18 EST

In R3893 : correct an NPE in AbstractLineStyleToggleState

Comment 9 Vincent Lorenzo

2011-02-10 07:55:12 EST

In R3983 :
rewrite all mnemonics + 
add a Title for the Zoom Toolbar
change the papyrus icon

Comment 10 Vincent Lorenzo

2011-02-13 02:07:05 EST

In R4012  : add some comments in the class ZoomToolbar : I explain why we can't set an Image for the ZoomToolbar (used in the dialog for customize the Perspective)

Comment 11 Vincent Lorenzo

2011-03-10 04:15:05 EST

In R4232 : Change the selectAll command used! Now, we use org.eclipse.ui.edit.selectAll, because there is already an handler for this action, which works fine with EditParts.

Comment 12 Vincent Lorenzo

2011-03-10 05:06:06 EST

In R4234 : Minor change on the zoom Toolbar, in order avoid future bugs with Nattable.

Comment 13 Remi Schnekenburger

2012-02-13 10:27:27 EST

Still missing Cut, Copy, Paste, … from popup menu in Diagram Editors.

postponed in 0.9.

Comment 14 Vincent Lorenzo

2016-09-13 07:09:05 EDT

This bug can be marked as closed fixed.