Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330102

Summary:	[site_login] ends in a login loop, no login possible -- possible issue with VPN and Proxy clients
Product:	Community	Reporter:	Thomas Neustupny <thn-d>
Component:	Website	Assignee:	phoenix.ui <phoenix.ui-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P4	CC:	chris.guindon, denis.roy, thn-d, webmaster
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:
Bug Blocks:	435405

Description Thomas Neustupny

2010-11-12 10:41:03 EST

Build Identifier: 

On http://eclipse.org/forums/, I clicked on "Login". Then I got a login page. After submitting my credentials, I got a "Welcome Back, Thomas" page (successfully logged in). From there, either clicking on "Continue" or "Return to previous page" returns to the login page.

I tried Firefox and IE, deleted cache and cookies, no change.

This is a showstopper for me, I can't use my account anymore. How else could I contact the UML2 people? I tried many hacks/workarounds, but nothing worked. Is all this related to the fact that I was not active in the forum for several months?

Reproducible: Always

Steps to Reproduce:
1. On http://eclipse.org/forums/, click on "Login"
2. Enter credential (in my case: thn-d@gmx.de)
3. Submit -> successfully logged in
4. "Continue" -> Login page again

Comment 1 Thomas Neustupny

2010-11-13 04:46:40 EST

I tried again today, and the problem was gone. So what happened?

Comment 2 Thomas Neustupny

2010-11-16 11:22:16 EST

I got news on this: today I figured that the problem occurs when a VPN (Check Point VPN) is running on my Win XP machine, and a connection is established. I verified that closing the connection gets rid of the problem. Hope this info is useful. For me it's solved. Which one is the appropriate status now?

Comment 3 Denis Roy

2010-11-16 13:11:51 EST

Thomas, this is great info; thanks for the follow-up.  For some reason, certain proxy (and now VPN) environments seem to cause issues with our login.

The proxy issue was known; that VPNs can cause this is news to me, but knowing this will likely help others figure out the problem.

I'll leave this open for investigation, but reduce the severity.

Thanks again for the great report.

Comment 4 Denis Roy

2014-06-11 14:26:03 EDT

I found a bug... which may be responsible for what we've been seeing here.

in session.class.php, when we load a session, we call maintenance().

That maintenance function is used to delete stale sessions.  The query, however, does much more:

1. DELETE FROM sessions
2. WHERE (updated_at < DATE_SUB(NOW(), INTERVAL 7 DAY) AND is_persistent = 0) 
3. OR (subnet = '" . $this->getClientSubnet() . "' AND gid <> '" . $App->sqlSanitize($this->getGID(), null) . "')
4. OR updated_at < DATE_SUB(NOW(), INTERVAL 1 YEAR)

Line 3 essentially deletes all sessions from the same subnet as you're on...  except your own.

Proposed change does two things:

1. Removes line "3" from the above query
2. Touches the "updated at" time, which was the intention of the field in the first place.

https://git.eclipse.org/r/28378


Once this change has been in production for a while, we'll be able to trim sessions based on the (more accurate) updated_at field.

Comment 5 Denis Roy

2014-06-16 14:33:10 EDT

Thomas if you're still capable of doing so, would it be possible to test the change?  It was deployed late last week.

Comment 6 Christopher Guindon

2015-01-19 16:17:18 EST

Can we close this bug?

Comment 7 Denis Roy

2015-02-12 11:46:02 EST

I think so.