Bugzilla – Full Text Bug Listing
| Summary: | [commons] allow disabling and enabling notifications for certain event types | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Torkild Resheim <torkildr> | ||||||
| Component: | Mylyn | Assignee: | Torkild Resheim <torkildr> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | steffen.pingel | ||||||
| Version: | unspecified | Keywords: | contributed | ||||||
| Target Milestone: | 3.5 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 327712, 331424 | ||||||||
| Attachments: |
|
||||||||
|
Description
Torkild Resheim
I'm taking a stab at this one and is wondering about the "selected" attribute in "org.eclipse.mylyn.commons.notificaitons.event" declarations. It is currently used for selected state of events in the preference setting UI. Now I assume this is just temporary? Or is this the default value of the event notification? (In reply to comment #1) > I'm taking a stab at this one and is wondering about the "selected" attribute in > "org.eclipse.mylyn.commons.notificaitons.event" declarations. It is currently > used for selected state of events in the preference setting UI. Now I assume > this is just temporary? Or is this the default value of the event notification? Yes, this is to determine the default initialization for an event notifications. The state for the actual notifications is kept in NotificationAction which should be persisted (but is not yet). (In reply to comment #2) > Yes, this is to determine the default initialization for an event notifications. > The state for the actual notifications is kept in NotificationAction which > should be persisted (but is not yet). OK. Thanks. Created attachment 184688 [details]
Patch to fix the issue
I've implemented a mechanism for persisting the NotificationEvent and NotificationAction settings. Filtering has been added to the NotificationService and the UI in the NotificationsPreferencesPage is handling the settings. I'm not so sure about the UI and the data model though. Currently it is only possible to change enablement of the various actions. The state of these are propagated to the events when changed. I'm don't know if this was how it was intended to work.
Anyhow we got a working solution and I guess we could always tweak it later on.
Created attachment 184689 [details]
mylyn/context/zip
Great stuff! I have committed the patch with two minor modifications: I added a null check where the model was being loaded to handle the case when no memento existed and I commented out the code that adds the "Test" button. I like the idea of a preview but I think we need a better place for the button. Thanks for applying the patch Steffen. I was not sure about the "Test" button either. You're right that it did not look too good where it was. |