Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 330052

Summary:

Breakage related to sticky views

Product:

[Modeling] EMF

Reporter:

Caspar D. <caspar_d>

Component:

cdo.core

Assignee:

Caspar D. <caspar_d>

Status:

CLOSED FIXED

QA Contact:

Eike Stepper <stepper>

Severity:

normal

Priority:

CC:

saulius.tvarijonas, stepper, vaisegid

Version:

4.0

Flags:

stepper: review+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch	none
Patch v2 - ready to be committed	none

Description Caspar D.

2010-11-11 23:25:37 EST

Sticky views are broken in 2 ways:

1. The mechanism that excludes objects that were committed by the
sticky session, from stickiness, works on a per-transaction basis,
while it should work on a per-session basis. Result is that currently,
a view can't find an objects that was newly committed by a transaction
in the same session.

2. The sticky-or-not decision logic does not take into account that
the view requesting the revision might be an audit view; and so
audit-view behavior has been broken since the introduction of sticky
behavior.

Will provide testcases and patch shortly.

Comment 1 Caspar D.

2010-11-11 23:43:32 EST

Created attachment 182952 [details]
Patch

This patch moves much of the sticky logic from the view/tx to the
session, where it belongs (since stickiness is a session property),
and in addition it properly excludes audit view from sticky behavior.

Comment 2 Eike Stepper

2010-11-13 03:54:34 EST

Created attachment 183074 [details]
Patch v2 - ready to be committed

Just reformatted slightly.

Comment 3 Caspar D.

2010-11-14 22:40:28 EST

Committed to HEAD

Comment 4 Eike Stepper

2011-06-23 03:37:17 EDT

Available in R20110608-1407