Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329904

Summary: [tests] Missing quotes in test case launch configurations
Product: [Modeling] OCL Reporter: Axel Uhl <eclipse>
Component: CoreAssignee: OCL Inbox <mdt-ocl-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ed
Version: unspecified   
Target Milestone: 3.1.0   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Fixes the quoting in the launches for me ed: iplog+

Description Axel Uhl CLA 2010-11-10 09:10:29 EST
Build Identifier: CVS Head of 2010-11-10

With a workspace checked out to a directory with spaces in its path name, the test case launch configurations don't work. The following patch fixes this for me:

### Eclipse Workspace Patch 1.0
#P org.eclipse.ocl.ecore.tests
Index: launches/org.eclipse.ocl.ecore.tests (Standalone Backtracking).launch
===================================================================
RCS file: /cvsroot/modeling/org.eclipse.mdt/org.eclipse.ocl/tests/org.eclipse.ocl.ecore.tests/launches/org.eclipse.ocl.ecore.tests (Standalone Backtracking).launch,v
retrieving revision 1.3
diff -u -r1.3 org.eclipse.ocl.ecore.tests (Standalone Backtracking).launch
--- launches/org.eclipse.ocl.ecore.tests (Standalone Backtracking).launch	5 Jan 2010 07:47:24 -0000	1.3
+++ launches/org.eclipse.ocl.ecore.tests (Standalone Backtracking).launch	10 Nov 2010 14:08:59 -0000
@@ -18,7 +18,7 @@
 <stringAttribute key="org.eclipse.jdt.junit.TEST_KIND" value="org.eclipse.jdt.junit.loader.junit4"/>
 <stringAttribute key="org.eclipse.jdt.launching.MAIN_TYPE" value="org.eclipse.ocl.ecore.tests.AllTestsBacktracking"/>
 <stringAttribute key="org.eclipse.jdt.launching.PROJECT_ATTR" value="org.eclipse.ocl.ecore.tests"/>
-<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Dorg.eclipse.ocl.ecore.tests=${resource_loc:/org.eclipse.ocl.ecore.tests}&#13;&#10;-Dorg.eclipse.ocl.ecore=${resource_loc:/org.eclipse.ocl.ecore}&#13;&#10;-Dorg.eclipse.ocl.ecore.tests.nodebug=true&#13;&#10;-ea"/>
+<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Dorg.eclipse.ocl.ecore.tests=&quot;${resource_loc:/org.eclipse.ocl.ecore.tests}&quot;&#13;&#10;-Dorg.eclipse.ocl.ecore=&quot;${resource_loc:/org.eclipse.ocl.ecore}&quot;&#13;&#10;-Dorg.eclipse.ocl.ecore.tests.nodebug=true&#13;&#10;-ea"/>
 <booleanAttribute key="org.eclipse.tptp.platform.jvmti.client.ATTR_EXEC_OBJ_ALLOC_SITE" value="false"/>
 <booleanAttribute key="org.eclipse.tptp.platform.jvmti.client.ATTR_HEAP_COLLECT_INSTANCE" value="true"/>
 </launchConfiguration>
Index: launches/org.eclipse.ocl.ecore.tests (Standalone).launch
===================================================================
RCS file: /cvsroot/modeling/org.eclipse.mdt/org.eclipse.ocl/tests/org.eclipse.ocl.ecore.tests/launches/org.eclipse.ocl.ecore.tests (Standalone).launch,v
retrieving revision 1.2
diff -u -r1.2 org.eclipse.ocl.ecore.tests (Standalone).launch
--- launches/org.eclipse.ocl.ecore.tests (Standalone).launch	16 Dec 2009 07:38:44 -0000	1.2
+++ launches/org.eclipse.ocl.ecore.tests (Standalone).launch	10 Nov 2010 14:08:59 -0000
@@ -18,7 +18,7 @@
 <stringAttribute key="org.eclipse.jdt.junit.TEST_KIND" value="org.eclipse.jdt.junit.loader.junit4"/>
 <stringAttribute key="org.eclipse.jdt.launching.MAIN_TYPE" value="org.eclipse.ocl.ecore.tests.AllTests"/>
 <stringAttribute key="org.eclipse.jdt.launching.PROJECT_ATTR" value="org.eclipse.ocl.ecore.tests"/>
-<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Dorg.eclipse.ocl.ecore.tests=${resource_loc:/org.eclipse.ocl.ecore.tests}&#13;&#10;-Dorg.eclipse.ocl.ecore=${resource_loc:/org.eclipse.ocl.ecore}&#13;&#10;-Dorg.eclipse.ocl.ecore.tests.nodebug=true&#13;&#10;-ea"/>
+<stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-Dorg.eclipse.ocl.ecore.tests=&quot;${resource_loc:/org.eclipse.ocl.ecore.tests}&quot;&#13;&#10;-Dorg.eclipse.ocl.ecore=&quot;${resource_loc:/org.eclipse.ocl.ecore}&quot;&#13;&#10;-Dorg.eclipse.ocl.ecore.tests.nodebug=true&#13;&#10;-ea"/>
 <booleanAttribute key="org.eclipse.tptp.platform.jvmti.client.ATTR_EXEC_OBJ_ALLOC_SITE" value="false"/>
 <booleanAttribute key="org.eclipse.tptp.platform.jvmti.client.ATTR_HEAP_COLLECT_INSTANCE" value="true"/>
 </launchConfiguration>


Reproducible: Always

Steps to Reproduce:
1. Checkout OCL projects into a workspace with spaces in path name
2. try to launch test configuration "org.eclipse.ocl.ecore.tests (Standalone Backtracking).launch" or "org.eclipse.ocl.ecore.tests (Standalone).launch"
Comment 1 Ed Willink CLA 2010-11-10 12:07:41 EST
I know it's tiny but it is helpful to keep files as files and so avoid cut and paste problems. The inline text does not seem to be a valid patch. Perhaps the lines have been wrapped.

Please attach.
Comment 2 Axel Uhl CLA 2010-11-10 12:19:59 EST
Created attachment 182835 [details]
Fixes the quoting in the launches for me
Comment 3 Ed Willink CLA 2010-11-20 07:31:33 EST
Fixed while fixing Bug 329946; forgot there where two bugs.
Comment 4 Ed Willink CLA 2011-05-27 03:13:40 EDT
Closing