Bugzilla – Full Text Bug Listing
| Summary: | [Dialogs] new API DialogSettings#getOrCreateSection(IDialogSettings, String) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> | ||||
| Component: | UI | Assignee: | Markus Keller <markus.kell.r> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Susan McCourt <susan> | ||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | daniel_megert | ||||
| Version: | 3.7 | ||||||
| Target Milestone: | 3.7 M4 | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Discussed at today's Platform UI meeting. Markus, please go ahead. Fixed in HEAD. Verified in I20101206-1800. Filed bug 332012 to make sure the new API gets used. |
Created attachment 182811 [details] Fix HEAD Many clients of IDialogSettings#getSection(String) are not interested in whether the section already exists or not. They just want that section. Since there's no API for this on IDialogSettings, client code is full of boilerplate code like this: IDialogSettings section = MyPlugin.getDefault().getDialogSettings(). getSection(sectionName); if (section == null) { section = MyPlugin.getDefault().getDialogSettings(). addNewSection(sectionName); } Since we can't change IDialogSettings any more, the best solution I see is to add this as a static method DialogSettings#getOrCreateSection(IDialogSettings, String)