Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329897

Summary:

add configuration icon to service message dialog

Product:

z_Archived

Reporter:

Torkild Resheim <torkildr>

Component:

Mylyn

Assignee:

Torkild Resheim <torkildr>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

steffen.pingel

Version:

unspecified

Keywords:

contributed

Target Milestone:

3.5

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

327712

Attachments:

Description	Flags
Patch to add a button for opening preferences	steffen.pingel: iplog+
mylyn/context/zip	none
Icon for hovered notification configuration button	none
Icon for notification configuration button	none

Description Torkild Resheim

2010-11-10 08:45:49 EST

In order to make configuration of service messages more accessible we should add a new configuration icon to the message dialogs. When clicking this icon the "General > Notifications" dialog will open on the appropriate item. See https://bugs.eclipse.org/bugs/attachment.cgi?id=182805 for example. Also see bug 327712.

Comment 1 Torkild Resheim

2010-11-12 04:37:38 EST

Note that bug bug #263528 has a similar function although this code has been commented out for the 3.4 release.

Comment 2 Torkild Resheim

2010-11-12 04:46:30 EST

Created attachment 182970 [details]
Patch to add a button for opening preferences

This patch will add a button to the ServiceMessageControl for opening the associated preferences. As the preference dialog opened is for service events; the button will only show if there is an EventId for the displayed service message.

Comment 3 Torkild Resheim

2010-11-12 04:46:33 EST

Created attachment 182971 [details]
mylyn/context/zip

Comment 4 Torkild Resheim

2010-11-12 04:48:15 EST

Created attachment 182972 [details]
Icon for hovered notification configuration button

Comment 5 Torkild Resheim

2010-11-12 04:48:50 EST

Created attachment 182973 [details]
Icon for notification configuration button

Comment 6 Torkild Resheim

2010-11-12 04:52:52 EST

Note that the icons will go into o.e.m.c.ui/icons/eview16/

Comment 7 Steffen Pingel

2010-11-12 06:17:28 EST

Reopening to apply patch.

Comment 8 Steffen Pingel

2010-11-12 13:00:56 EST

Thanks! I have applied the patch.

Comment 9 Torkild Resheim

2010-11-12 13:37:38 EST

Thanks Steffen. I've added a patch to bug 327712 that takes advantage of this enhancement.