Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329878

Summary: Blocking enhancement request for our product; ignoring inaccessible projects
Product: [WebTools] WTP ServerTools Reporter: Rob Stryker <stryker>
Component: wst.serverAssignee: Angel Vera <arvera>
Status: RESOLVED FIXED QA Contact: Angel Vera <arvera>
Severity: normal    
Priority: P3    
Version: 3.2   
Target Milestone: 3.2.3   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/109006
Whiteboard:
Attachments:
Description Flags
Extracts the continue call none

Description Rob Stryker CLA 2010-11-10 04:58:50 EST 
Currently when a publish request comes in for a module which has an inaccessible project, that request is ignored with a simple "continue" call. Our product (and I'll probably push this into JEE Tools if it works first) wants to enable deletion participants, which lead to inacessible projects.

The reason we want to use deletion participants is because during a deletion event, the project still exists, as does its module, which means a publish request can still cast into the module delegate's class (and other subclasses) to get custom module information. If the publish request happens AFTER the deletion, our publishers only get access to a DeletedModule, which is next ot useless for us.

I would like to see the ignoring extracted into a protected method.
Comment 1 Rob Stryker CLA 2010-11-10 04:59:50 EST 
Created attachment 182797 [details]
Extracts the continue call
Comment 2 Rob Stryker CLA 2010-11-10 11:17:04 EST 
Angel give this a look if you can...
Comment 3 Angel Vera CLA 2010-11-10 16:29:56 EST 
Seems small and reasonable. The implementation doesn't seem to affect other server adopters as a new method (API) is created that defaults to the current behaviour. Thus no change in behaviour for adopters. 

I have to double check but we should be able to get this into 323 because of the above statement.

The only question I have are: 
- no javadocs?
- what kind of refression testing was done?
Comment 4 Angel Vera CLA 2010-12-08 15:14:09 EST 
changes committed to HEAD with the corresponding java doc. I tested a few scenarios no impact.
Comment 5 Angel Vera CLA 2010-12-08 15:17:45 EST 
changes committed to 32M
Comment 6 Angel Vera CLA 2010-12-08 16:09:52 EST 
released to 32M
Comment 7 Angel Vera CLA 2010-12-08 16:10:00 EST 
released to HEAD
Comment 8 Angel Vera CLA 2010-12-08 16:10:14 EST 
fixed
Comment 9 Eclipse Genie CLA 2017-10-11 16:35:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/109006