Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329868

Summary: [launch] The default protocol chosen by the launch for gdbserver should be TCP
Product: [Tools] CDT Reporter: Marc Khouzam <marc.khouzam>
Component: cdt-debug-dsf-gdbAssignee: Marc Khouzam <marc.khouzam>
Status: RESOLVED FIXED QA Contact: Marc Khouzam <marc.khouzam>
Severity: normal    
Priority: P3 CC: cdtdoug, pawel.1.piech
Version: 8.0Flags: pawel.1.piech: review+
Target Milestone: 7.0.2   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Fix marc.khouzam: iplog-

Description Marc Khouzam CLA 2010-11-09 22:03:17 EST
Created attachment 182784 [details]
Fix

When launching a remote launch, we support both the serial protocol and the TCP protocol to connect to gdbserver.  Currently, the launch defaults to using the serial protocol and the user must change that manually.

From what I know, the vast majority of people use the TCP protocol, so I feel it really should be the default.
Comment 1 Marc Khouzam CLA 2010-11-09 22:06:12 EST
Committed to HEAD.
Pawel, can you review this 2 liner?  Thanks
Comment 2 CDT Genie CLA 2010-11-09 22:23:03 EST
*** cdt cvs genie on behalf of mkhouzam ***
Bug 329868 - Make TCP the default protocol when populating a remote launch tab.

[*] GdbServerDebuggerPage.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/launching/GdbServerDebuggerPage.java?root=Tools_Project&r1=1.2&r2=1.3
Comment 3 Pawel Piech CLA 2010-11-09 23:24:25 EST
The logic appears fine to me.
Comment 4 Marc Khouzam CLA 2010-11-22 09:49:13 EST
Committed to 7_0
Comment 5 CDT Genie CLA 2010-11-22 10:23:04 EST
*** cdt cvs genie on behalf of mkhouzam ***
Bug 329868: Default protocol for remote debugging should be TCP.

[*] GdbServerDebuggerPage.java 1.2.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/launching/GdbServerDebuggerPage.java?root=Tools_Project&r1=1.2&r2=1.2.2.1