Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329840

Summary:

[Viewers] Clicking on a checkbox in a CheckboxTreeViewer selects the row.

Product:

[Eclipse Project] Platform

Reporter:

riesem

Component:

SWT

Assignee:

Scott Kovatch <skovatch>

Status:

RESOLVED FIXED

QA Contact:

Silenio Quarti <Silenio_Quarti>

Severity:

normal

Priority:

CC:

darnells, prakash, skovatch

Version:

3.7

Target Milestone:

3.7 M4

Hardware:

Macintosh

OS:

Mac OS X

Whiteboard:

Bug Depends on:

Bug Blocks:

334048

Attachments:

Description	Flags
Fix	none

Description riesem

2010-11-09 13:10:32 EST

Build Identifier: 20100617-1415

On Mac clicking on a checkbox in a CheckboxTreeViewer causes the corresponding row to be selected.

This does not happen on Windows. Also I could not find an Apple style guide that would require it to be like that. I think the behavior should be the same in this case.

P.s. I was not sure about the product and component and copied them form another bug related to the CheckboxTreeViewer.

Reproducible: Always

Steps to Reproduce:
1. Select an element in a CheckboxTreeViewer.
2. Click on the checkbox in a different row.
3. The selection changes.

Comment 1 Hitesh

2010-11-10 12:42:24 EST

Prakash, could you please test this on your machine and confirm the bug ? Thanks!!

Comment 2 Prakash Rangaraj

2010-11-11 01:48:11 EST

Tried SWT Snippet# 274 and checking does selects the the entire row. Moving the bug to SWT.

Also shouldn't it select/deselect when the space bar is pressed?

Comment 3 Scott Kovatch

2010-11-11 12:06:17 EST

(In reply to comment #2)

> Also shouldn't it select/deselect when the space bar is pressed?

Only if "Full Keyboard Access" is turned on. (System Preferences -> Keyboard -> Keyboard Shortcuts)

Comment 4 riesem

2010-11-11 13:29:21 EST

Clicking the triangle to expand or collapse a parent element does not have this effect. There seems to be a "save zone" for that. Maybe it could just be extended to contain the check box as well.

Comment 5 Scott Kovatch

2010-11-11 13:54:30 EST

I seem to recall fixing this at one point. It may be that I did it for Table and not Tree.

Comment 6 Steven Darnell

2010-11-15 17:51:15 EST

Scott -- I would be very appreciative of and willing to test a patch for this bug. Thanks, Steve.

Comment 7 Scott Kovatch

2010-11-16 00:38:09 EST

Created attachment 183182 [details]
Fix

I had worked on this at one point, and fortunately saved my work. There was one last problem to iron out; it's all working now.

Comment 8 Scott Kovatch

2010-11-16 00:38:47 EST

(In reply to comment #6)
> Scott -- I would be very appreciative of and willing to test a patch for this
> bug. Thanks, Steve.

If you know how to build the SWT, go ahead. I'll check it in Tuesday AM.

Comment 9 Scott Kovatch

2010-11-16 12:20:04 EST

Fixed > 20101116.

Comment 10 Scott Kovatch

2010-11-16 12:24:42 EST

Comment 11 riesem

2010-11-19 12:02:28 EST

Great. It works for me too. Thanks for the fix.

Comment 12 Steven Darnell

2011-01-11 18:02:51 EST

Scott -- Is it possible to also commit this fix to the 3.6.x branch?  We are planning to releasing an RCP app based on 3.6.2.  Unfortunately, I am unable to wait to the release of 3.7.0.

Comment 13 Scott Kovatch

2011-01-11 18:09:59 EST

I have cloned the bug for 3.6.2. We don't have a 3.6.2 plan just yet; I'll see what I can do.