Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329835

Summary: [EditorMgmt] WorkbenchEditorsDialog's save operation simply reuses a progress monitor repeatedly for every editor to be saved
Product: [Eclipse Project] Platform Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Remy Suen <remy.suen>
Severity: normal    
Priority: P3    
Version: 3.7   
Target Milestone: 3.7 M4   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
WorkbenchEditorsDialog patch v1 none

Description Remy Suen CLA 2010-11-09 12:41:43 EST
The progress monitor is passed to the editor's doSave(IProgressMonitor) without any regard for what the previous editor might've called on the editor.
Comment 1 Remy Suen CLA 2010-11-09 12:49:23 EST
Created attachment 182737 [details]
WorkbenchEditorsDialog patch v1
Comment 2 Remy Suen CLA 2010-11-09 12:50:21 EST
(In reply to comment #1)
> Created an attachment (id=182737) [details]
> WorkbenchEditorsDialog patch v1

Fix released to CVS HEAD.
Comment 3 Remy Suen CLA 2010-12-07 08:09:00 EST
Verified by source code inspection with I20101206-1800 on Windows XP.