Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329796

Summary:

[Hibernate] Support queryXRefs()

Product:

[Modeling] EMF

Reporter:

Michal Tkacz <Michal.Tkacz>

Component:

cdo.core

Assignee:

Martin Taal <mtaal>

Status:

CLOSED FIXED

QA Contact:

Eike Stepper <stepper>

Severity:

enhancement

Priority:

CC:

mtaal

Version:

4.0

Keywords:

noteworthy

Target Milestone:

---

Flags:

stepper: review+

Hardware:

All

OS:

All

Whiteboard:

Power to the People

Attachments:

Description	Flags
Attachment for support xref, property values and xref	none
patch for xref, blob, property	none
Patch	none
Patch for property, xref and blob support	none
Patch v4	none
Patch v5 - ready to be committed	none

Description Michal Tkacz

2010-11-09 09:43:04 EST

Current implementation (in HibernateStoreAccessor) simply throws an UnsupportedOperationException.

Comment 1 Michal Tkacz

2010-11-09 09:52:47 EST

See also bug 329799.

Comment 2 Martin Taal

2010-11-13 02:36:16 EST

Created attachment 183069 [details]
Attachment for support xref, property values and xref

Note, this patch needs to be checked by me some more. Is only attached for archiving purpose.

Comment 3 Martin Taal

2010-11-13 03:15:13 EST

Created attachment 183070 [details]
patch for xref, blob, property

For archiving purposes

Comment 4 Martin Taal

2010-11-13 03:16:28 EST

Comment on attachment 183070 [details]
patch for xref, blob, property

Error in patch, resubmitting

Comment 5 Martin Taal

2010-11-13 03:16:52 EST

Created attachment 183071 [details]
Patch

For archiving purposes

Comment 6 Martin Taal

2010-11-14 00:06:02 EST

Created attachment 183087 [details]
Patch for property, xref and blob support

This patch adds support for:
- set/get store properties
- xref
- blob
- supports custom types using a String

Comment 7 Eike Stepper

2010-11-14 01:55:00 EST

1) There are some System.err.println() calls. Do you want to replace them by TRACER calls or remove them?
2) There is a _temp folder that I accidentally reviewed. Is it still needed?
3) Your test plugin says "Require-Bundle: org.hibernate". Is it possible that you replace that by package imports?

Comment 8 Eike Stepper

2010-11-14 01:59:36 EST

Created attachment 183088 [details]
Patch v4

Seems that I have broken something here because all test cases in ComplexTest are failing if (and only if) they are executed as part of AllTests.

Still investigating...

Comment 9 Eike Stepper

2010-11-14 02:11:25 EST

Created attachment 183089 [details]
Patch v5 - ready to be committed

Started review from scratch. Thi spatch only contains reformattings and I removed the _temp folder. Please think about points 1) and 3) in comment #7...

Comment 10 Martin Taal

2010-11-14 17:42:36 EST

Solution committed to cvs

Reaction to remarks from Eike:
1) There are some System.err.println() calls. Do you want to replace them by
TRACER calls or remove them?
MT> Sorry, have been removed/commented out
2) There is a _temp folder that I accidentally reviewed. Is it still needed?
MT>> my mistake should not be committed
3) Your test plugin says "Require-Bundle: org.hibernate". Is it possible that
you replace that by package imports?
MT>> Accidentally this dependency is not needed anymore. I removed it. The reason that I choose require-bundle over import packages is that I got a access-denied errors when using import packages.

gr. Martin

Comment 11 Eike Stepper

2011-06-23 03:40:02 EDT

Available in R20110608-1407