Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329728

Summary: Enable CDT Disassembly view with TCF debugger
Product: [Tools] TCF Reporter: Anton Leherbauer <aleherb+eclipse>
Component: CoreAssignee: Doug Schaefer <cdtdoug>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: enhancement    
Priority: P3 CC: cdtdoug
Version: unspecified   
Target Milestone: 0.4.0   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 329729    
Attachments:
Description Flags
Add Disassembly view support for TCF
cdtdoug: iplog+
Force load of adapter
cdtdoug: iplog+
Patch take 2 cdtdoug: iplog-

Description Anton Leherbauer CLA 2010-11-09 03:02:24 EST
Created attachment 182684 [details]
Add Disassembly view support for TCF

Attached patch adds support for using the CDT Disassembly view with the TCF debugger front-end.
Comment 1 Anton Leherbauer CLA 2010-11-09 07:15:46 EST
Created attachment 182700 [details]
Force load of adapter

I just noticed that the adapter factory which creates the TCFDisassemblyBackend is not loaded if the org.eclipse.tm.tcf.cdt.ui plug-in is not yet activated.  This patch makes sure the factory is loaded anyway by forcing the adapter manager to activate the plug-in.
Comment 2 Doug Schaefer CLA 2010-11-10 12:59:12 EST
Hi Toni. Is this the complete patch? There seems to be stuff missing.
Comment 3 Doug Schaefer CLA 2010-11-10 16:58:16 EST
Created attachment 182854 [details]
Patch take 2
Comment 4 Doug Schaefer CLA 2010-11-10 16:59:53 EST
I have applied the modified patch.
Comment 5 Doug Schaefer CLA 2010-11-10 17:01:42 EST
Taking the assignment since I applied the patch.
Comment 6 Anton Leherbauer CLA 2010-11-11 02:01:08 EST
(In reply to comment #2)
> Hi Toni. Is this the complete patch? There seems to be stuff missing.

Sorry, Subversive seems to have created the patch incorrectly.
Anyway, thanks for fixing it!
Comment 7 Martin Oberhuber CLA 2010-11-11 08:47:51 EST
Hm... should Toni's contribution be iplog+ ? He is a CDT committer but not a TCF committer. See also his contribution on bug 329729 which Eugene placed an iplog+ on.
Comment 8 Doug Schaefer CLA 2010-11-11 13:22:00 EST
Comment on attachment 182684 [details]
Add Disassembly view support for TCF

Yup, my bad. It doesn't need an IP review, but it should show up in the log.
Comment 9 Doug Schaefer CLA 2010-11-17 11:35:49 EST
Comment on attachment 182700 [details]
Force load of adapter

I ended up applying this patch because Toni was right :).
Comment 10 Doug Schaefer CLA 2011-05-17 10:49:14 EDT
Moving bugs to new home for IP log.
Comment 11 Martin Oberhuber CLA 2013-06-05 06:26:38 EDT
Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3