Bugzilla – Full Text Bug Listing
| Summary: | new features and products | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Jeff McAffer <jeffmcaffer> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Component: | Releng | Assignee: | Kim Moir <kim.moir> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Severity: | normal | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Priority: | P3 | CC: | daniel_megert, kim.moir, tjwatson | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Version: | 3.7 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Target Milestone: | 3.7 M4 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Hardware: | PC | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Bug Blocks: | 327724 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Description
Jeff McAffer
Jeff, what platforms do you want the starter kit to run on? I notice you have copied executables from for win32.win32.x86 and win32.win32.x86_64 but the product file specifies launcher arguments for the mac. Its a great question. Fortunately we are headless to the whole WS thing is out of the mix. Since the product is headless it is a console app and we need the console launcher. That is only an issue on Windows thus the inclusion of eclipsec.exe 32/64-bit. For the mac I did a p2.inf that adds a symlink so it can be run easily from the command line. So, platforms. I would think Win 32/64, linux 32/64 and Mac 32/64 should cover most of the bases. So do you just want metadata generated for all the platforms in the repository so people can install this product from the repo? Or do you want individual zips for all these platforms? zip downloads. This is a starter kit that people should be able to get, unzip and run. Of course, the metadata should be in the repo to but we're really after the zips for the .product. Jeff, what text do you want on the Equinox download page to describe the starter kit? We should lkely have a new section as the second section on the download page. Should read OSGi Starter Kit A useful collection of Equinox bundles packaged as a ready to run system. This include the framework, p2 and other frequently used service implementations. This section can be collapsed by default to save space since there will be 5-6 download entries. Created attachment 182744 [details]
patch
Created attachment 182745 [details]
mylyn/context/zip
Thanks Kim. I noticed at the end of the patch the following equinox-OSGi-starterkit-@buildid@-win32.win32.x86..zip Two things. There are doubled '.' at the end. and can we have the file called EclipseRT-OSGi-StarterKit-... Created attachment 182755 [details]
patch
Created attachment 182756 [details]
mylyn/context/zip
Created attachment 182761 [details]
patch
extra space
Created attachment 182762 [details]
mylyn/context/zip
Created attachment 182772 [details]
patch to fix equinox build page generation
Created attachment 182773 [details]
mylyn/context/zip
Created attachment 182774 [details]
patch to include product feature in master equinox feature
since it's not included in other features
Created attachment 182775 [details]
mylyn/context/zip
Created attachment 182781 [details]
patch
Created attachment 182782 [details]
mylyn/context/zip
Created attachment 182823 [details]
patch
Created attachment 182824 [details]
mylyn/context/zip
Created attachment 182825 [details]
patch
sorry for all the patch spam :-)
Created attachment 182826 [details]
mylyn/context/zip
Created attachment 182827 [details]
patch
Created attachment 182828 [details]
mylyn/context/zip
Created attachment 182845 [details]
patch to not specify feature version in product file
Created attachment 182846 [details]
patch to reorganize run.xml
released for N20101110-2000. The test build is here if you want to look at the zips. https://hudson.eclipse.org/hudson/view/Eclipse%20and%20Equinox/job/eclipse-equinox-test-N/208/artifact/builds/transfer/files/bogus/equinox/drops/N20101110-1554/ I sniffed around the starter kit and it looks good with one set of issues around the root files/executables. It seems like there is some extra build magic happening to get a set of executables and root files rather than following what is defined in the .product file. In the starter kit .product we setup the executable to be called rt but that's not what is happening on the various platforms. On the mac the executable is Eclipse.app. It should be rt.app and the eclipse symlink should be named rt. There is a p2.inf that creates the rt symlink but the link is broken because the app is not rt.app. On windows ideally the only executable would be rt.exe and this would actually be a copy of eclipsec.exe. For now we have manually copied eclipsec.exe, named it rtc.exe and contribute it via root files. It seems like this is not coming through. On linux the executable is called eclipse (should be rt) and there is an swt cairo lib in the root. The icon.xpm is the Eclipse one as opposed to the EclipseRT one but we did not contribute something there. Not really sure there should be one... I committed too soon... There is a topic around how to get the latest launchers on windows and have them named/branded as described in the .product. Perhaps we can write some p2.inf actions that will do the work (eg. delete eclipse.exe and rename eclipsec.exe?) On the other platforms we should be good with the info in the .product and p2.inf. sigh... Also forgot to mentino that the linux build has several about entries in the root that should not be there. On reflection, it looks like the executables feature is being included and bring along things. This is a separate issue from the releng topic for now. I'll open a separate bug in launcher or pde build to work on that. Notwithstanding, having rt.exe etc be there would be good. We should still be able to do the branding as normal. See Bug 330113 for a discussion of the executables feature issues For completeness, there are five new features. I have added them to the maps file and tagged them with the current content. Going forward they will need to be tagged in the normal process. The five features are: feature@org.eclipse.equinox.core.feature feature@org.eclipse.equinox.p2.core.feature feature@org.eclipse.equinox.p2.extras.feature feature@org.eclipse.core.runtime.feature feature@org.eclipse.equinox.starterkit.product.feature Created attachment 183035 [details]
zip names were incorrect on download page
I get 404s for the starter kits on
http://download.eclipse.org/equinox/drops/N20101114-2000/index.php
Regarding comment #35, yes I released a fix for this on Friday but didn't tag the builder because I was testing other bugs. I've released this fix for tonight's build. I talked to Andrew regarding how to rename the executables and generate the appropriate metadata
Here is the result of our conversation.
<eclipse.brand.p2.artifacts>
10:06:04 AM: Andrew Niefer: <eclipse.brand.p2.artifacts launcherName="${launcherName}" config="linux.gtk.x86" iconsList="${launcherIcons}" launcherProvider="${launcherProvider}" productId="org.eclipse.webide" productVersion="0.0.2.${p2.product.qualifier}" repository="${p2.build.repo}" tempDirectory="${assemblyTempDir}" />
10:08:25 AM: Andrew Niefer: launcerProvider=org.eclipse.equinox.executable
10:25:00 AM: Andrew Niefer: buildConfiguration.xml/
10:25:27 AM: Andrew Niefer: <path id="launcher.paths">
<fileset dir="${reposource}" includes="plugins/org.eclipse.equinox.launcher*" />
<!-- the built version of the org.eclipse.equinox.executable feature -->
<dirset dir="${buildDirectory}" includes="features/org.eclipse.equinox.executable*" /> <-- replace with built version
</path>
Created attachment 183960 [details]
patch to branch executables
Created attachment 183961 [details]
mylyn/context/zip
Created attachment 184292 [details]
patch
Created attachment 184293 [details]
patch
Created attachment 184294 [details]
mylyn/context/zip
The branding is fixed for N20101201-2000. I started one up and it just starts the osgi console, I guess this is expected :-) |