Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329677

Summary: [type hierarchy] view must honor package name abbreviation setting
Product: [Eclipse Project] JDT Reporter: Deepak Azad <deepakazad>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, markus.kell.r, raksha.vasisht, rthakkar
Version: 3.7   
Target Milestone: 3.7 M4   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
screenshot
none
screenshot after initial fix
none
More fixes none

Description Deepak Azad CLA 2010-11-08 10:02:20 EST
Created attachment 182620 [details]
screenshot

I use package name abbreviation to make it easier to parse information in Java views, and to reduce clutter. But Type Hierarchy view does not respect this setting... this is irritating

(Call Hierarchy works correctly)

Steps
- Enable 'Show qualified type names' from the Type Hierarchy view menu
- Enable package name abbreviation
- Open type hierarchy on something
Comment 1 Markus Keller CLA 2010-11-08 11:41:27 EST
I fully agree, fixed in HierarchyLabelProvider.

I've also fixed it in the quick hierarchy (in HierarchyInformationControl). The difference there is that we use the UI string to match against the filter pattern, so the behavior of the filter changes as well (which is good, IMO).

Please speak up if you disagree.
Comment 2 Deepak Azad CLA 2010-11-08 12:21:21 EST
Thanks for the fix!

(In reply to comment #1)

> I've also fixed it in the quick hierarchy (in HierarchyInformationControl). The
> difference there is that we use the UI string to match against the filter
> pattern, so the behavior of the filter changes as well (which is good, IMO).
+1. This means faster filtering. Markus can you please fix it in Ctrl+O Ctrl+O as well, so that the behavior is consistent everywhere.
Comment 3 Deepak Azad CLA 2010-11-08 12:34:02 EST
Created attachment 182641 [details]
screenshot after initial fix

Markus, the original problem I highlighted is fixed. But the setting is still not respected in 2 other places in the view (see screenshot)
Comment 4 Deepak Azad CLA 2010-11-08 12:34:34 EST
Reopening...
Comment 5 Markus Keller CLA 2010-11-08 13:29:21 EST
Created attachment 182644 [details]
More fixes

Fixes in Quick Outline, history dialogs, view descriptions, and type hierarchy members viewer.
Comment 6 Markus Keller CLA 2010-11-08 13:29:58 EST
Fixed in HEAD.
Comment 7 Dani Megert CLA 2010-11-09 02:55:49 EST
Please add this item to the test plan, especially to test the filtering part.
Comment 8 Raksha Vasisht CLA 2010-12-07 01:45:49 EST
Verified for 3.7M4 with I20101206-1800.
Comment 9 Rajesh CLA 2010-12-07 04:44:19 EST
Verified in I20101206-1800.