Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329673

Summary:	NPE in Branch Selection dialog
Product:	[Technology] EGit	Reporter:	Jens Baumgart <jens.baumgart>
Component:	UI	Assignee:	Jens Baumgart <jens.baumgart>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.sohn
Version:	0.10.0
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Jens Baumgart

2010-11-08 08:53:54 EST

NPE happens when selecting a branch name using the arrow keys and pressing return.
By moving the arrow key the node does not get selected.

java.lang.NullPointerException
at org.eclipse.egit.ui.internal.dialogs.AbstractBranchSelectionDialog$2.open(AbstractBranchSelectionDialog.java:166)
at org.eclipse.jface.viewers.StructuredViewer$2.run(StructuredViewer.java:845)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
at org.eclipse.jface.viewers.StructuredViewer.fireOpen(StructuredViewer.java:843)
at org.eclipse.jface.viewers.StructuredViewer.handleOpen(StructuredViewer.java:1131)
at org.eclipse.jface.viewers.StructuredViewer$6.handleOpen(StructuredViewer.java:1235)
at org.eclipse.jface.util.OpenStrategy.fireOpenEvent(OpenStrategy.java:264)
at org.eclipse.jface.util.OpenStrategy.access$2(OpenStrategy.java:258)
at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:298)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)

Comment 1 Jens Baumgart

2010-11-08 09:17:37 EST

- search a branch that was not selected before
- press tab
- now the branch has the focus, but no selection
- press enter => NPE

Comment 2 Jens Baumgart

2010-11-08 12:06:25 EST

Fix proposed: http://egit.eclipse.org/r/#change,1866

Comment 3 Matthias Sohn

2010-11-09 18:20:52 EST

merged as 91a8f3bfc8c25b4a975ceed8e5ab87077fb59121