Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329660

Summary: Exception logged trying to view a diff having renamed file.
Product: [Technology] EGit Reporter: James Blackburn <jamesblackburn+eclipse>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: robin.rosenberg
Version: 0.10.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux-GTK   
Whiteboard:

Description James Blackburn CLA 2010-11-08 04:20:20 EST 
Eclipse EGit (Incubation)	0.10.0.201011021512	org.eclipse.egit.feature.group

Having renamed a class in an egit repository within Eclipse. I get this exception logged double clicking on the file in the commit viewer.

org.eclipse.core.runtime.CoreException: Path src/org/eclipse/core/internal/resources/ComputeProjectOrder.java not in commit d1b4bb479c5aa36fbfc2ea875da3be8abd4d9660.
	at org.eclipse.egit.core.internal.storage.CommitFileRevision.locateBlobObjectId(CommitFileRevision.java:121)
	at org.eclipse.egit.core.internal.storage.CommitFileRevision.getStorage(CommitFileRevision.java:71)
	at org.eclipse.egit.ui.internal.FileRevisionTypedElement.fetchContents(FileRevisionTypedElement.java:63)
	at org.eclipse.egit.ui.internal.StorageTypedElement.cacheContents(StorageTypedElement.java:72)
	at org.eclipse.egit.ui.internal.GitCompareFileRevisionEditorInput.ensureContentsCached(GitCompareFileRevisionEditorInput.java:82)
	at org.eclipse.egit.ui.internal.GitCompareFileRevisionEditorInput.prepareCompareInput(GitCompareFileRevisionEditorInput.java:351)
	at org.eclipse.team.ui.synchronize.SaveableCompareEditorInput.prepareInput(SaveableCompareEditorInput.java:235)
	at org.eclipse.compare.CompareEditorInput.run(CompareEditorInput.java:483)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
Comment 1 Robin Rosenberg CLA 2013-05-11 16:44:23 EDT 
There is no NPE anymore, but one might expect the diff to actually diff against the older renamed file
Comment 2 Robin Rosenberg CLA 2013-05-15 14:38:27 EDT 
Apparently fixed.