Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329654

Summary: Make all TCF sub services recognized as operating against TCF connection service
Product: [Tools] TCF Reporter: Liping Ke <liping.ke>
Component: CoreAssignee: Anna Dushistova <anna.dushistova>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: enhancement    
Priority: P3 CC: anna.dushistova, cdtdoug, jessica.zhang, lianhao.lu, liping.ke
Version: unspecified   
Target Milestone: 0.4.0   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
Add ITCFService interface as conn index for all TCF sub services
none
Add ITCFService interface as conn index for all TCF sub services
none
Add ITCFService interface as conn index for all TCF sub services anna.dushistova: iplog+

Description Liping Ke CLA 2010-11-08 01:28:49 EST
Build Identifier: 

Currently, process and file service use its own Service class type as the key to search TCF connector service. When more terminal/shell service added, we'd better make all those sub services share the same connector service (eg, login session will be shared by all, avoid user repeatedly input login information). Add a new mark up interface ITCFService is needed.

Reproducible: Always
Comment 1 Liping Ke CLA 2010-11-08 01:38:11 EST
Created attachment 182587 [details]
Add ITCFService interface as conn index for all TCF sub services

This patch add ITCFService as the mark up interface for all TCF sub services. So that all subservices use this ITCFService interface as the search key for connector service will the same connection. When authentication login session is introduced, the login service will be shared by those service too. It avoids repeatedly filling login user/password information.
Comment 2 Anna Dushistova CLA 2010-11-08 04:31:58 EST
Hi Liping, why do you have WindRiver copyright with years 2007, 2010 in your ITCFService class?
If you cloned it some other file, could you please add "Adapted from <classname>" and preserve the original copyright. If not, then probably you should have Intel copyright with only 2010.
Comment 3 Liping Ke CLA 2010-11-08 04:36:28 EST
Created attachment 182597 [details]
Add ITCFService interface as conn index for all TCF sub services

Hi&#65292; Anna

The old patch has wrong lic information. I should change windriver to Intel. Thanks for pointing it out!

Regards,
criping
Comment 4 Liping Ke CLA 2010-11-08 04:41:25 EST
Oh, Just a minute. Maybe I should say I inherit it from Windriver. I will send you another patch in a moment!

criping

(In reply to comment #3)
> Created an attachment (id=182597) [details]
> Add ITCFService interface as conn index for all TCF sub services
> 
> Hi&#65292; Anna
> 
> The old patch has wrong lic information. I should change windriver to Intel.
> Thanks for pointing it out!
> 
> Regards,
> criping
Comment 5 Liping Ke CLA 2010-11-08 04:48:25 EST
Created attachment 182598 [details]
Add ITCFService interface as conn index for all TCF sub services

Hi, Anna
This is the latest patch update lic information.

Thanks a lot!
criping
Comment 6 Anna Dushistova CLA 2010-11-08 05:54:40 EST
This patch is applied.
Comment 7 Doug Schaefer CLA 2011-05-17 10:50:53 EDT
Moving bugs to new home for IP log.
Comment 8 Martin Oberhuber CLA 2013-06-05 06:28:42 EDT
Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3