Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329581

Summary: [Compatibility] View perspectiveExtensions to placeholder folders do not show up
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Remy Suen <remy.suen>
Status: RESOLVED FIXED QA Contact: Remy Suen <remy.suen>
Severity: major    
Priority: P3 CC: eiswind
Version: 1.0   
Target Milestone: 4.1 M4   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
ModeledPageLayout patch v1 none

Description Remy Suen CLA 2010-11-05 14:43:55 EDT
The view is correctly added to the folder but it is not visible on startup.

Perspective factory code:
public void createInitialLayout(IPageLayout factory) {
  factory.createPlaceholderFolder(
      "leftFolder", IPageLayout.LEFT, 0.25f, //$NON-NLS-1$
      factory.getEditorArea());
}

View extension:

<view id="org.eclipse.ui.views.ResourceNavigator"
    relationship="stack"
    relative="leftFolder"
    visible="true">
</view>
Comment 1 Remy Suen CLA 2010-11-05 14:49:12 EDT
Created attachment 182512 [details]
ModeledPageLayout patch v1

The view was being contributed correctly to the placeholder folder but the stack itself was not being rendered (since it was a placeholder folder). The fix is to ask it to be rendered if a visible view has been contributed to it.
Comment 2 Remy Suen CLA 2010-11-05 14:51:26 EDT
(In reply to comment #1)
> Created an attachment (id=182512) [details]
> ModeledPageLayout patch v1

Fix released to CVS HEAD.

Thanks for the bug report, Thomas! Please let us know if you encounter other problems with the 4.x SDK.
Comment 3 Remy Suen CLA 2010-11-05 14:51:32 EDT
Whoops.
Comment 4 Thomas Kratz CLA 2010-11-06 04:53:36 EDT
Thanks for fixing this so quickly. I'll try the patches right now.