Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329433

Summary:	Make default package more visible and easy to edit.
Product:	[WebTools] Dali JPA Tools	Reporter:	Dimitar Giormov <dimitar.giormov>
Component:	Diagram Editor	Assignee:	Project Inbox <dali.diagrameditor-inbox>
Status:	NEW ---	QA Contact:	Stefan Dimov <stefan.dimov>
Severity:	enhancement
Priority:	P3	CC:	kaloyan, petya.sabeva, shaun.smith
Version:	0.5	Keywords:	plan
Target Milestone:	Future
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Dimitar Giormov

2010-11-04 09:16:12 EDT

What I think currently is a little hidden in the JPA editor is the use of default package for the entities and its editing capabilities.

My thoughts on editing:
This prevents the user of easily structuring the project. There should be a way to modify the package easier. (one idea is to include it in the pictogram element)

My thoughts on entity creation:
In my opinion the more suitable target will be to get the vendor and use it as core for the package and the name of the project for the second part of the package name (e.g. vendor: org.eclipse, Project name address-book => package: org.eclipse.address-book

And finally the default package is somehow not visible, since it resides in the project properties.
Unfortunately I do not have any concrete idea on how this could be improved.

So what do you think?

Comment 1 Shaun Smith

2011-01-12 12:06:27 EST

Default (or maybe more accurately "current") package name should be specified per project or even per diagram (when multiple diagrams per project are supported).  

Specification of the current package should be easy and direct.  Instead of defaulting to a global value initial package could be specified the first time someone tries to create an Entity.  They could be prompted with the standard package selection dialog that allow for both selection and creation.  Dragging an entity into an empty diagram could also set the current package to that of the entity.  "Auto switching" the current package to that of the last dragged entity could be an additional optional feature.

Changing the current package could be done via a pop-up menu in the diagram and would open the standard package selection dialog.  Also, the current package could be displayed somewhere in the palette and clicking on it could once again open the standard package dialog.

Comment 2 Stefan Dimov

2011-01-13 10:03:29 EST

Yes, it can be done better. 

BTW, the package can be specified per project. There is a coresponding project property page with the same options as the global preference page. The values set in the project property page override the globals.

Comment 3 Shaun Smith

2011-01-13 11:20:46 EST

(In reply to comment #2)
Where do I find the project level default package setting?  I'm not able to find it in the project properties dialog.

Comment 4 Kaloyan Raev

2011-01-13 12:30:29 EST

Look for Java Persistence > JPA Diagram Editor property page. It's available for projects with the JPA facet.

Comment 5 Shaun Smith

2011-01-13 13:25:53 EST

(In reply to comment #4)
> Look for Java Persistence > JPA Diagram Editor property page. It's available
> for projects with the JPA facet.

Hmm, nothing there for me.  I installed 0.5 into Java EE Helios SR1 and looked at project properties for both JPA 1.0 and 2.0 projects but the only thing visible under Java Persistence is Errors/Warnings.  I don't see any relevant exceptions in the Errors view.  I have other things installed on top of SR1 in addition to the JPA Diagram Editor so perhaps the problem is due to an interaction with one of them?

Comment 6 Kaloyan Raev

2011-01-13 13:30:07 EST

Now I can see that it only shows for JPA 1.0 projects, but not for JPA 2.0 ones. 
Could you check again for JPA 1.0 projects?

Comment 7 Stefan Dimov

2011-01-17 11:33:09 EST

I've created a new bug jus(In reply to comment #6)
> Now I can see that it only shows for JPA 1.0 projects, but not for JPA 2.0
> ones. 
> Could you check again for JPA 1.0 projects?

I've creates a new bug only for this:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=334536

Comment 8 Neil Hauge

2011-10-27 11:16:29 EDT

The 3.2 target now represents the Juno release.

Comment 9 Petya Sabeva

2012-05-04 01:56:16 EDT

Retargeting this bug to the Kepler realease (3.3).

Comment 10 Petya Sabeva

2012-09-11 11:03:06 EDT

*** Bug 329304 has been marked as a duplicate of this bug. ***

Comment 11 Petya Sabeva

2013-05-08 08:05:30 EDT

Retargeting this bug to 3.4 release.

Comment 12 Neil Hauge

2014-09-30 16:56:38 EDT

Bulk move to Dali 3.5 as Dali 3.4 has shipped.

Comment 13 Neil Hauge

2015-05-14 14:11:13 EDT

Deferring from 3.5 to Future target.