Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329432

Summary:

Commons Httpclient is missing the Apache NOTICE file

Product:

[Tools] Orbit

Reporter:

Martin Oberhuber <mober.at+eclipse>

Component:

bundles

Assignee:

Martin Oberhuber <mober.at+eclipse>

Status:

RESOLVED FIXED

QA Contact:

Severity:

critical

Priority:

Version:

unspecified

Target Milestone:

Indigo M5

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

327661

Attachments:

Description	Flags
Patch fixing the issue	none
Updated patch, fixing XHTML validation in about.html	none

Description Martin Oberhuber

2010-11-04 09:06:43 EDT

The commons httpclient binary bundle is missing the Apache NOTICE file (or NOTICE.txt). This is severe, because without that NOTICE file the redistribution violates clause 4d of the Apache 2.0 license.

I checked the original HTTPClient sources and they do contain a NOTICE file:
http://www.gtlib.gatech.edu/pub/apache//httpcomponents/commons-httpclient/source/commons-httpclient-3.1-src.zip

The Eclipse / Orbit distro however does not, and the respective hyperlink in about.html is broken. Also, the copyright-to-year is incorrect (2005 according to Eclipse about.html but 2007 according to the Apache NOTICE file).

org.apache.commons.httpclient_3.1.0.v201005080502.jar : about.html
  caution: filename not matched:  about_files/NOTICE.txt

Comment 1 Martin Oberhuber

2010-12-07 02:53:16 EST

Created attachment 184685 [details]
Patch fixing the issue

Attached patch fixes the issue.

Comment 2 Martin Oberhuber

2010-12-07 04:02:38 EST

Created attachment 184691 [details]
Updated patch, fixing XHTML validation in about.html

Comment 3 Martin Oberhuber

2010-12-07 04:30:20 EST

Released the Fix >= I20101207 (Indigo M5).