Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329406

Summary: NOTICE.txt seems outdated for Jetty 6.1.23
Product: [Tools] Orbit Reporter: Martin Oberhuber <mober.at+eclipse>
Component: bundlesAssignee: Simon Kaegi <simon_kaegi>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: david_williams, gunnar
Version: unspecified   
Target Milestone: Indigo M5   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch v1 none

Description Martin Oberhuber CLA 2010-11-03 18:37:25 EDT
The Helios SR1 version of Jetty 6.1.23, which ships with Eclipse Platform, contains this NOTICE.txt:

==============================================================
 Jetty Web Container 
 Copyright 1995-2006 Mort Bay Consulting Pty Ltd
==============================================================
...

but the original Jetty-6.1.23 archive contains this NOTICE.txt header and much more contents after that header:

==============================================================
 Jetty Web Container 
 Copyright 1995-2009 Mort Bay Consulting Pty Ltd
==============================================================
...

The outdated NOTICE.txt is IMO problematic since it seems to violate section 4.(d) of the Apache 2.0 license, which requires faithfully reproducing the original NOTICE file when redistributing.

I also found that NOTICE.txt is not linked from the jetty about.html, which also seems problematic since section 4.(d) of the Apache 2.0 license requires making the NOTICE file available and I'm not sure whether having the file contained inside the JAR is sufficient to satisfy this.
Comment 1 Martin Oberhuber CLA 2010-12-07 06:48:37 EST
Created attachment 184707 [details]
Patch v1

Here is a patch, fixing the issue for Jetty v6_1_23.

I do not know whether the Eclipse subset of Jetty includes "The default JSP implementation provided by the Glassfish JSP engine", or "The win32 Java Service Wrapper (v3.2.3)". If not, then the respective sections can perhaps be removed from NOTICE.txt.

Please check and commit, thanks.
Comment 2 Simon Kaegi CLA 2010-12-07 14:22:03 EST
Thanks Martin.