Bugzilla – Full Text Bug Listing
| Summary: | [releng] 4.1 needs fixed Orbit builds | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Paul Webster <pwebster> | ||||
| Component: | UI | Assignee: | Andrew Niefer <aniefer> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ahunter.eclipse, aniefer, bsd, dj.houghton, kim.moir, remy.suen, sgandon, tjwatson | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 4.1 M4 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 329376 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Paul Webster
Andrew, as an aside we include both the 1.6 and 1.7 versions of the batik libraries (they're not singletons). Our plugin specifies org.apache.batik.css;bundle-version="[1.6.0,1.7.0)", so I'm not sure why we're pulling in the 1.7 versions of batik.util PW Our bundle (org.eclipse.e4.ui.css.core) gets resolved to batik.css_1.6.0. It is the dependency from batik.css that pulls in the other util bundles, and the version attributes there were meaningless so the resolver is free to resolve against whatever version it likes, and in general higher versions get selected. Also, I notice our map files actually list both 1.6 and 1.7 versions of the batik.util bundles. As well as multiple versions of some other orbit bundles. PDE/Build will fetch the highest version in the map file unless the feature specifies otherwise. org.w3c.dom.svg has the same issue: [...MANIFEST.MF...] Bundle-SymbolicName: org.w3c.dom.svg Require-Bundle: org.w3c.dom.smil;version="[1.0.0,1.1.0)" Export-Package: org.w3c.dom.svg;version="1.1.0" [...] Just to certain, I scanned through all the bundles that I have available for 'Require-Bundle.*;version=' and found 4: ==> org.apache.batik.css_1.6.0.v200912221622.jar Require-Bundle: org.apache.batik.util;version="[1.6.0,1.7.0)",org.w3c.css.sac;version="[1.3.0,1.4.0)",org.w3c.dom.svg;version="[1.1.0,1.3.0)" ==> org.apache.batik.util_1.6.0.v200805290154.jar Require-Bundle: org.apache.batik.util.gui;version="[1.6.0,1.7.0)" ==> org.apache.batik.xml_1.6.0.v200805290154.jar Require-Bundle: org.apache.batik.util;version="[1.6.0,1.7.0)" ==> org.w3c.dom.svg_1.1.0.v200806040011.jar Require-Bundle: org.w3c.dom.smil;version="[1.0.0,1.1.0)" Please use bug329376 to report any additional orbit bundles that need fixing. (In reply to comment #4) > org.w3c.dom.svg has the same issue: > > [...MANIFEST.MF...] > Bundle-SymbolicName: org.w3c.dom.svg > Require-Bundle: org.w3c.dom.smil;version="[1.0.0,1.1.0)" > Export-Package: org.w3c.dom.svg;version="1.1.0" Please note that "version" attribute on Export-Package and Import-Package is valid. We are only interested in Require-Bundle cases here. > [...] Created attachment 182413 [details]
Patch for the Batik v1.7 bundles with the issue.
Committed the fixes for the Batik v1.7 bundles with the issue and released as v201011041433.
(In reply to comment #7) > Created an attachment (id=182413) [details] > Patch for the Batik v1.7 bundles with the issue. > > Committed the fixes for the Batik v1.7 bundles with the issue and released as > v201011041433. I guess this should have gone in Bug 329376. I have updated the map files to use http://download.eclipse.org/tools/orbit/downloads/drops/I20101104194033/ for org.apache.batik.css org.apache.batik.util org.apache.batik.util.gui org.wsc.dom.svg Any other orbit bundles remain with their old map entries *** Bug 358542 has been marked as a duplicate of this bug. *** |