Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329358

Summary: [Compatibility] Workbench will not come up when trying to restore editors that were not persisted correctly
Product: [Eclipse Project] e4 Reporter: Olivier Thomann <Olivier_Thomann>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Remy Suen <remy.suen>
Severity: major    
Priority: P3 CC: remy.suen
Version: unspecified   
Target Milestone: 4.1 M4   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
both logs full of NPE errors
none
zipped Deltas.xml file
none
EditorReference patch v1 none

Description Olivier Thomann CLA 2010-11-03 10:57:12 EDT
Created attachment 182300 [details]
both logs full of NPE errors

Once I got bug 329355, I could not open a new editor anymore. So I decide to restart and now the whole workspace doesn't start properly: no toolbar, no key binding, I cannot open new editors,...
Comment 1 Olivier Thomann CLA 2010-11-03 10:58:22 EDT
Created attachment 182301 [details]
zipped Deltas.xml file
Comment 2 Remy Suen CLA 2010-11-03 11:04:13 EDT
The log feels to me like it's the same problem as the one Boris reported in bug 319807.
Comment 3 Remy Suen CLA 2010-11-03 14:14:50 EDT
Created attachment 182319 [details]
EditorReference patch v1
Comment 4 Remy Suen CLA 2010-11-03 14:17:48 EDT
(In reply to comment #3)
> Created an attachment (id=182319) [details]
> EditorReference patch v1

A strange shutdown has caused the editor(s) to not be persisted properly. I've tightened up the code in EditorReference to ward off against such cases. Workaround is to just delete the deltas.xml file.

Fixed in CVS HEAD.

I'll close this bug since the infinite LogView logging problem is illustrated by bug 319807.

Thanks for the bug report and attachments, Olivier!
Comment 5 Remy Suen CLA 2010-12-07 14:43:38 EST
Verified that I20101207-0250 starts up with the deltas.xml provided by comment 1 on Windows XP.