Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329253

Summary:	OpenBreakpointMarkerAction calls "internal" setFocus() method on IWorkbenchParts
Product:	[Eclipse Project] Platform	Reporter:	Remy Suen <remy.suen>
Component:	Debug	Assignee:	Platform-Debug-Inbox <platform-debug-inbox>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	darin.eclipse, pawel.1.piech, pwebster
Version:	3.7	Flags:	pawel.1.piech: review+
Target Milestone:	3.7 M4
Hardware:	All
OS:	All
Whiteboard:

Description Remy Suen

2010-11-02 09:16:43 EDT

setFocus() is called in line 79 of OpenBreakpointMarkerAction. This is not a method that clients should be calling (as spec'd in the javadoc).

Comment 1 Darin Wright

2010-11-02 10:13:02 EDT

Looks like we should use the IWorkbenchPage.openEditor(...) API that accepts an "activate" boolean parameter instead.

Comment 2 Darin Wright

2010-11-02 11:02:58 EDT

Fixed in HEAD.

Comment 3 Pawel Piech

2011-05-06 17:34:59 EDT

Reviewed fix.