Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329245

Summary:

Variable 'flags' in UnixFileNatives is never used

Product:

[Eclipse Project] Platform

Reporter:

Tomasz Zarna <tomasz.zarna>

Component:

Resources

Assignee:

Pawel Pogorzelski <pawel.pogorzelski1>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

john.arthorne, pawel.pogorzelski1, Szymon.Brandys

Version:

3.7

Target Milestone:

3.7 M4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Fix v01	none
Patch_02	none

Description Tomasz Zarna

2010-11-02 06:05:45 EDT

It looks that variable 'flags' in org.eclipse.core.internal.filesystem.local.unix.UnixFileNatives is never used. Guys, is it safe to remove it? A patch doing that attached.

Comment 1 Tomasz Zarna

2010-11-02 06:06:10 EDT

Created attachment 182196 [details]
Fix v01

Comment 2 Szymon Brandys

2010-11-03 04:32:37 EDT

*** Bug 329281 has been marked as a duplicate of this bug. ***

Comment 3 Pawel Pogorzelski

2010-11-03 05:07:48 EDT

Created attachment 182275 [details]
Patch_02

It's better to OR the flag with previous value not to wipe off other attributes.

Couldn't come up with a test since the change can't be detected via EFS API. We simply don't support the attributes that were erased during the operation.

Comment 4 Szymon Brandys

2010-11-03 08:29:24 EDT

The fix is in HEAD. Thanks Pawel.