Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 329169

Summary:	feature build.properties loaded repeatedly
Product:	[Eclipse Project] PDE	Reporter:	Jeff McAffer <jeffmcaffer>
Component:	Build	Assignee:	pde-build-inbox <pde-build-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	aniefer
Version:	3.7	Keywords:	performance
Target Milestone:	3.7 M7
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Jeff McAffer

2010-10-31 21:00:15 EDT

In BuildDirector.computeElements() it looks like the build.properties for the current feature is repeatedly loaded by calling 
   			Properties featureProperties = getBuildProperties(feature);
inside the for loop iterating over the contents of the feature.  The build.properties for the feature should not change during the build (at least not while the feature is being processed) so a small performance improvement could be had by moving that line to before the for loop.

Comment 1 Andrew Niefer

2011-03-24 17:04:36 EDT

fixed