Bugzilla – Full Text Bug Listing
| Summary: | [WTP Jetty Adaptor] Patch to Modify template of WebSocket wizard to generate WebSocket #onFragment method. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [RT] Jetty | Reporter: | Angelo ZERR <azerr> | ||||
| Component: | other | Assignee: | Jesse McConnell <jesse.mcconnell> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | azerr, gregw | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 7.1.x | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Angello, it's great that you have a websocket wizard. But can you add a note to it that the server side api's are all protypes and are expected to change. Jesse, I've assigned this patch to you as I'm not up to speed with the latest state of angelos' contribution. (In reply to comment #1) Hi Greg, > Angello, > > it's great that you have a websocket wizard. I'm happy that the wizard idea please you. It generate a basic Jetty WebSocket and modify the web.xml. I think it should be cool if WebSocket client Javascript will be generate too. > But can you add a note to it > that the server side api's are all protypes and are expected to change. You mean to set this senetence to the Class generated? I think you can do it if you wish. If you see my very simple patch you will see that websocket_servlet.javajet is modified. It's a JET template which generate the WebSocketServletTemplate used to generate the Jetty WebSOcket Java code. Jesse or Greg, could you modify websocket_servlet.javajet (which will modify WebSocketServletTemplate) to add this comment? Thanks. It will avoid that I create a new patch and you will able to add the well comments as you think. > > Jesse, I've assigned this patch to you as I'm not up to speed with the latest > state of angelos' contribution. Regards Angelo greg, yes I'll take care of these things for the time being as I am pushing to get this out the door and released asap. [doubloon]jetty-wtp/jetty-wtp> svn commit -m "Bug 329144 modify websocket template to generate WebSocket #onFragment" Adding VERSION.txt Sending org.eclipse.jst.server.jetty.ui.websocket/src/org/eclipse/jst/server/jetty/ui/websocket/internal/operations/WebSocketServletTemplate.java Sending org.eclipse.jst.server.jetty.ui.websocket/templates/websocket_servlet.javajet Transmitting file data ... Committed revision 2462. |
Created attachment 182105 [details] Patch to Modify template of WebSocket wizard to generate WebSocket #onFragment method. Hi, I send you a patch to to apply to org.eclipse.jst.server.jetty.ui.websocket project. This patch fix problem with WTP Websocket wizard wich doesn't generate onFragment method in the WebSocket implementation. Regards Angelo