Bugzilla – Full Text Bug Listing
| Summary: | BuildCommand #equals is wrong leading to loss of Builders with custom triggers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | James Blackburn <jamesblackburn+eclipse> | ||||
| Component: | Resources | Assignee: | Platform-Resources-Inbox <platform-resources-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | Flags: | john.arthorne:
review+
|
||||
| Version: | 3.7 | ||||||
| Target Milestone: | 3.7 M4 | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 329143 | ||||||
| Attachments: |
|
||||||
Looks good. Thanks James. I have released this to HEAD, but *not* for the I-build tomorrow so we can run some nightly builds before it goes out. |
Created attachment 182102 [details] test + fix 1 The BuildCommand #equals and #hashCode consider the full value in BuildCommand#trigger. As there are some meta bits used in trigger (for MASK_CONFIGURABLE, MASK_CONFIG_COMPUTED) #equals may yield false even if the two ICommands are equivalent. The result is that the currently active builder state can be lost during #setBuildSpec. Simple test + fix attached.