Bugzilla – Full Text Bug Listing
| Summary: | jUnit failures in jst.server.tomcat | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP ServerTools | Reporter: | Angel Vera <arvera> | ||||||
| Component: | jst.server | Assignee: | Angel Vera <arvera> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Angel Vera <arvera> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | darin.eclipse, david_williams, israelgd, john.arthorne, larryisaacs, tjbishop | ||||||
| Version: | 3.2 | ||||||||
| Target Milestone: | 3.2.3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| See Also: |
https://git.eclipse.org/r/109002 https://git.eclipse.org/r/108999 https://git.eclipse.org/r/109003 https://git.eclipse.org/r/109836 https://git.eclipse.org/r/109835 https://git.eclipse.org/c/servertools/webtools.servertools.git/commit/?id=83499cd59a24d79fc4f2fdd2765af74c00b3dbe6 https://git.eclipse.org/c/servertools/webtools.servertools.git/commit/?id=a0e753e6dc23ae8123f1b15256a922d4d9508472 |
||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Angel Vera
I ran the test locally a few times with the 3.2.3 build and I didn't get any failures. Looking at the out logs, I see the following errors which seems to be related to the changes I did recently for Bug# 328067: ENTRY org.eclipse.core.jobs 4 2 2010-10-28 16:28:09.970 !MESSAGE An internal error occurred during: "Starting Tomcat v5.0 Server at localhost". !STACK 0 java.lang.NoClassDefFoundError: org/eclipse/debug/ui/DebugUITools at org.eclipse.wst.server.ui.internal.SaveEditorPrompter.setDebugSaveBeforeLaunching(SaveEditorPrompter.java:62) at org.eclipse.wst.server.ui.internal.SaveEditorPrompter.setDebugNeverSave(SaveEditorPrompter.java:69) at org.eclipse.wst.server.core.internal.Server.startImpl2(Server.java:3213) at org.eclipse.wst.server.core.internal.Server.startImpl(Server.java:3163) at org.eclipse.wst.server.core.internal.Server$StartJob.run(Server.java:359) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) I don't quite recall the history (had to do with not shipping "java source" in binary folders, I believe) but jst.server.tomcat.core has some "pre-compiled jars" in it, I believe. See org.eclipse.jst.server.tomcat.runtime.50.loader-src.zip org.eclipse.jst.server.tomcat.runtime.50.loader.jar org.eclipse.jst.server.tomcat.runtime.55.loader-src.zip org.eclipse.jst.server.tomcat.runtime.55.loader.jar org.eclipse.jst.server.tomcat.runtime.60.loader-src.zip org.eclipse.jst.server.tomcat.runtime.60.loader.jar org.eclipse.jst.server.tomcat.runtime.70.loader-src.zip org.eclipse.jst.server.tomcat.runtime.70.loader.jar Do these need to be recompiled with the recent changes, checked into cvs, and released? FYI: The org.eclipse.jst.server.tomcat.runtime.??.loader jars are copied to Tomcat as part of the "Serve modules without publishing" feature. Their code only runs within Tomcat and wouldn't affect anything or be affected by anything running in Eclipse. Created attachment 182219 [details] logs from the junit run Darin, Can you shed some light on this jUnit failure. This is related to the changes that you and I discussed for bug# 328067. The code changes are in Server.java ver. 1.188 as per: http://dev.eclipse.org/viewcvs/index.cgi/servertools/plugins/org.eclipse.wst.server.core/servercore/org/eclipse/wst/server/core/internal/Server.java?root=WebTools_Project&r1=1.187&r2=1.188 The jUnit is defined as a <ant target="core-test", which I think should be the right target, but why is my code detecting that org.eclipse.ui is active, when it shouldn't be. Darin, I missed adding you on my last comment. Do you have any ideas, this is related to the hang that we worked on bug# 328067. Take a look at comment #4 *** Bug 329475 has been marked as a duplicate of this bug. *** (In reply to comment #4) > The jUnit is defined as a <ant target="core-test", which I think should be the > right target, but why is my code detecting that org.eclipse.ui is active, when > it shouldn't be. I'm not familiar with the code that checks if the UI is running. Can you debug through the test to see why it thinks the UI is running? (In reply to comment #7) Unfortunately, this is happening in our automated jUnit test and I don't know how I could debug that. Maybe if I setup the same environment but that might take sometime. I committed changes to 32M to make the test UI, I am doing this as a workaround to the jUnit test. While we continue to investigate the problem John, Do you know of any better of way of checking if the UI is enabled or not? Sicne the changes for 32M work as a temp workaround. I am committed and released the same changes for HEAD(3.3) while we investigate where the failure comes from. Created attachment 184189 [details]
possible patch
Within a WTP adopter product we have support for headlessly starting a server and this problem is now occurring. Attached is a patch which modifies the check for determining if in a headless or UI environment. It solves the problem in my environment.
Thanks for the patch Troy, and the testing. It seems to do the trick. It still puzzles me why the the .ui plugin is detected as active but that will be a problem for a different time. committed to 32M committed to HEAD release to HEAD released to 32M New Gerrit change created: https://git.eclipse.org/r/109002 New Gerrit change created: https://git.eclipse.org/r/108999 New Gerrit change created: https://git.eclipse.org/r/109003 New Gerrit change created: https://git.eclipse.org/r/109836 New Gerrit change created: https://git.eclipse.org/r/109835 Gerrit change https://git.eclipse.org/r/109836 was merged to [master]. Commit: http://git.eclipse.org/c/servertools/webtools.servertools.git/commit/?id=83499cd59a24d79fc4f2fdd2765af74c00b3dbe6 Gerrit change https://git.eclipse.org/r/109835 was merged to [master]. Commit: http://git.eclipse.org/c/servertools/webtools.servertools.git/commit/?id=a0e753e6dc23ae8123f1b15256a922d4d9508472 |