| Summary: | Hyperlink detectors slowness causes copy delay | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] JSDT | Reporter: | Ian Tewksbury <itewksbu> | ||||||
| Component: | General | Assignee: | Ian Tewksbury <itewksbu> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Nitin Dahyabhai <thatnitind> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | jfanderson2 | ||||||
| Version: | 3.2.3 | Flags: | thatnitind:
review+
|
||||||
| Target Milestone: | 3.2.3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Ian Tewksbury
Created attachment 181985 [details]
Patch
Patch updates the JSDT hyperlink detectors to only run if the selected range is 0.
Let's rethink this. Since we control both the hyperlink objects that are created and what they hyperlinks do, let's move most of the computation into the implementor of IHyperlink#open(). Created attachment 182207 [details]
Patch - Update 1
This updated patch takes a more efficient approach by using the existing AST to determine if a selection is linkable or not. I implemented an ASTVisitor that dependent on the selections node type will decide if a hyperlink should be generated or not.
Right now i choose ASTNode.SIMPLE_NAME and ASTNode.QUALIFIED_NAME as the two node types we want to generate hyperlinks on. These choices were made by looking at the node types list and testing out in the editor. If there are any other node types that should be included let me know.
Committed, thanks, Ian! *** Bug 337781 has been marked as a duplicate of this bug. *** |