Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328924

Summary:	Export Target Plattform exports too much (complete plugins/features of the IDE)
Product:	[Eclipse Project] PDE	Reporter:	Bernhard Merkle <bernhard.merkle>
Component:	UI	Assignee:	PDE-UI-Inbox <pde-ui-inbox>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	normal
Priority:	P3	CC:	curtis.windatt.public, irbull, jeffmcaffer, svelganesh, thomas
Version:	3.7	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:
Bug Blocks:	304062

Description Bernhard Merkle

2010-10-28 09:50:03 EDT

Build Identifier: 

The feature is new since 3.6 but I think it should be improved significantly.

I think we should only export the selected plugins (also only for the selected platform). Think about putting a exported target platform to version control...
I only makes sense if only the selected files (plug-ins features) are added.
and nothing more...

to export the complete content (all plug-ins and features) does not make sense.
I mean, the user defined the target platform with lots of work 
and then suddenly we copy just all the files ? 

please see my comments on 
http://aniszczyk.org/2010/04/09/pdes-export-target-wizard/

Reproducible: Always

Comment 1 Curtis Windatt

2010-10-28 09:53:50 EDT

What do you mean by selected plug-ins and features?  The target export wizard should do exactly that, export all content from your current target.

Comment 2 Bernhard Merkle

2010-10-28 10:00:55 EDT

have also a look at bug 304062 which needs the functionality

Comment 3 Bernhard Merkle

2010-10-28 10:02:04 EDT

(In reply to comment #1)
> What do you mean by selected plug-ins and features?  The target export wizard
> should do exactly that, export all content from your current target.

In the target platform I can select _which_ plugins are necessary. (not all).

The export wizard should only export the selected and necessary plugins not all content.

Comment 4 Jeff McAffer

2010-10-28 10:32:11 EDT

I think you mean a scenario were you add some features (whatever) and then on the Content page of the editor, deselect certain bundles.  Right?  I agree that the export should follow what is selected on the Content page

Comment 5 Bernhard Merkle

2010-10-28 11:07:45 EDT

(In reply to comment #4)
> I think you mean a scenario were you add some features (whatever) and then on
> the Content page of the editor, deselect certain bundles.  Right?  I agree that
> the export should follow what is selected on the Content page

ok, thanks Jeff. I hopefully find the time to write a patch for this.

Comment 6 Bernhard Merkle

2010-10-29 03:54:57 EDT

another usefull feature when _composing_ a target platform would be:
- start with an empty target platform
- I have a bunch of my plugins which require other plugins (for the target platform)
- i would be useful if the target platform could be automatically derived from the manifest files from the above mentioned "bunch of my plugins) and add the necessary other plugins

I think this would make sense. maybe I should open an own bug id for this ?

Comment 7 Jeff McAffer

2010-11-02 11:17:23 EDT

(In reply to comment #6)
> I think this would make sense. maybe I should open an own bug id for this ?

Feels like a different topic.

FWIW, on the original topic, I should have a patch for this and the related bug 321870 later today.

Comment 8 Bernhard Merkle

2010-11-02 12:19:16 EDT

(In reply to comment #7)
> (In reply to comment #6)
> > I think this would make sense. maybe I should open an own bug id for this ?
> 
> Feels like a different topic.
bug 329271 now covers this


> 
> FWIW, on the original topic, I should have a patch for this and the related bug
> 321870 later today.
this is great news !

Comment 9 Jeff McAffer

2010-11-02 17:13:16 EDT

I've attached a patch to bug 321870 that should address the issue raised here as well as some other things.

Comment 10 Thomas Hallgren

2013-02-07 02:49:29 EST

Was this bug fixed by Jeffs patch? Should it be closed?

Comment 11 Curtis Windatt

2013-02-07 10:52:34 EST

(In reply to comment #10)
> Was this bug fixed by Jeffs patch? Should it be closed?

Yes, Jeff's patch fixes the export so only the plug-ins selected on the content page are included.  Closing as a duplicate.

*** This bug has been marked as a duplicate of bug 321870 ***