Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 328897

Summary: Thread leak when a debug session exits
Product: [Tools] PTP Reporter: Justin Kong <justinko>
Component: Debug UIAssignee: Greg Watson <g.watson>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch g.watson: iplog+

Description Justin Kong CLA 2010-10-27 19:14:19 EDT 
Build Identifier: 

When a parallel debug session terminates or runs to completion, AbstractProxyDebugClient.doShutdown is called. Any thread that enters this method can only exit when the current state of the AbstractProxyDebugClient is set to DISCONNECTED. This only occurs when another thread calls AbstractProxyDebugClient.doShutdown a second time.

In PTP 5.0, #doShutdown is only called once, and thus, every time a debug session finishes, a thread is leaked. The change that caused this is in Session.shutdown, as debugger.stopDebugger is no longer called.

Reproducible: Always
Comment 1 Justin Kong CLA 2010-10-27 19:16:13 EDT 
Created attachment 181897 [details]
Patch

Simple fix that just adds debugger.stopDebugger back to Session.shutdown.
Comment 2 Greg Watson CLA 2010-12-07 15:44:25 EST 
Applied to HEAD. Thanks!